Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-10] [HOLD] Highlight linked comment #23230

Closed
roryabraham opened this issue Jul 20, 2023 · 18 comments
Closed

[HOLD for payment 2023-10-10] [HOLD] Highlight linked comment #23230

roryabraham opened this issue Jul 20, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

HOLD on #23229

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.z8txm8vzzncc
Project: Comment Linking

Feature Description

As described in the design doc, add a different background color when a comment is linked to (in the URL)

Manual Test Steps

  1. Link to a specific comment
  2. Verify that the comment is highlighted

Automated Tests

None

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@perunt perunt mentioned this issue Sep 12, 2023
59 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 12, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 15, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 19, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 23, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 25, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 25, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Sep 28, 2023
Gonals added a commit that referenced this issue Oct 2, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2023
@melvin-bot melvin-bot bot changed the title [HOLD] Highlight linked comment [HOLD for payment 2023-10-10] [HOLD] Highlight linked comment Oct 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 10, 2023
@Gonals
Copy link
Contributor

Gonals commented Oct 17, 2023

not overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@situchan
Copy link
Contributor

@Gonals can you please add New Feature label for C+ payment?

@Gonals Gonals added the NewFeature Something to build that is a new item. label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 17, 2023
@peterdbarkerUK
Copy link
Contributor

@situchan @roryabraham - am I correct here this should be $500 for reviewing #27227?

@peterdbarkerUK peterdbarkerUK added Daily KSv2 and removed Weekly KSv2 labels Oct 17, 2023
@peterdbarkerUK
Copy link
Contributor

(Switching to daily to make sure it gets paid as a priority)

@situchan
Copy link
Contributor

@peterdbarkerUK yes $500 is correct

@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@peterdbarkerUK, @Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

@peterdbarkerUK
Copy link
Contributor

Ah dang it Melvin, this is sitting in my to-do queue this afternoon. Apologies for the delay @situchan, payment incoming.

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@situchan
Copy link
Contributor

No problem. Take your time. Thanks

@peterdbarkerUK
Copy link
Contributor

Thanks Situ! Offer sent :)

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

@peterdbarkerUK, @Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
@github-project-automation github-project-automation bot moved this from HOLD to Done in Comment Linking Oct 24, 2023
@peterdbarkerUK
Copy link
Contributor

my b yo

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

@peterdbarker I haven't received payment yet

@peterdbarkerUK
Copy link
Contributor

Ugh, Thanks @situchan - payment sent. I know this has happened to you a few times now, I'm really sorry. A good workman shouldn't blame his tools, but damn UpWork's interface is a special kind of torture. Thanks for your patience and the bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

4 participants