Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No system message when editing a task #23302

Closed
1 of 6 tasks
kavimuru opened this issue Jul 20, 2023 · 30 comments
Closed
1 of 6 tasks

No system message when editing a task #23302

kavimuru opened this issue Jul 20, 2023 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Create a task and add assignee
  2. Reassign the task to someone

Expected Result:

Should include a system message indicating that it was reassigned

Actual Result:

There is no message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1296.mp4

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689744951886999

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ecf0cd51093fcffd
  • Upwork Job ID: 1682151598616768512
  • Last Price Increase: 2023-07-20
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@thienlnam
Copy link
Contributor

This will have to be a mix of internal and external (We're currently not showing any system message when you edit the task, but we can surface that and include what was changed)

@MitchExpensify
Copy link
Contributor

Reproduced (Task was originally assigned to Franc)
image

@MitchExpensify
Copy link
Contributor

This will have to be a mix of internal and external

What label do you recommend @thienlnam ?

@thienlnam
Copy link
Contributor

thienlnam commented Jul 20, 2023

This is actually a new feature, so let's make it internal first until we're ready to update the front-end

@MitchExpensify MitchExpensify added the Internal Requires API changes or must be handled by Expensify staff label Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ecf0cd51093fcffd

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@MitchExpensify MitchExpensify added the NewFeature Something to build that is a new item. label Jul 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

Current assignee @MitchExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 20, 2023
@thienlnam thienlnam self-assigned this Jul 20, 2023
@thienlnam
Copy link
Contributor

Can handle the internal updates

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@thienlnam
Copy link
Contributor

We're making some changes to the assignee flow for this internal issue https://github.com/Expensify/Expensify/issues/299956 (Related to the privacy changes we need to make)

So let's hold this PR on that, so we don't have to re-do any of the work there

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2023
@thienlnam thienlnam changed the title No system message when reassigning an open task [HOLD 299956]No system message when reassigning an open task Aug 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2023
@MitchExpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@MitchExpensify
Copy link
Contributor

Still on hold for https://github.com/Expensify/Expensify/issues/299956

Same

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2023
@MitchExpensify
Copy link
Contributor

How is the PR coming along at this point @thienlnam ?

@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2023
@thienlnam
Copy link
Contributor

Haven't gotten started on this yet - though the linked issue https://github.com/Expensify/Expensify/issues/299956 is about to be wrapped up so I can start on this soon

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@thienlnam thienlnam changed the title [HOLD 299956]No system message when editing a task No system message when editing a task Nov 22, 2023
@thienlnam thienlnam added Monthly KSv2 and removed Weekly KSv2 labels Nov 22, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2023
@thienlnam
Copy link
Contributor

We still want to do this for consistency but it's not really a priority right now so I bumped to a monthly

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
@MitchExpensify
Copy link
Contributor

This doesn't fall into a wave IMO, do you agree @thienlnam ?

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2023
@thienlnam
Copy link
Contributor

This was being handled under VSB - finish tasks, but not part of a wave

@thienlnam
Copy link
Contributor

We didn't finish this by EOY - need to see if we still want to do this

@melvin-bot melvin-bot bot removed the Overdue label Jan 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@thienlnam
Copy link
Contributor

Spun up a BE PR, after that we can have a contributor handle the FE changes

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2024
@thienlnam
Copy link
Contributor

Web-E PR merged, need to create a new implementation issue for App

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@MitchExpensify
Copy link
Contributor

need to create a new implementation issue for App

Are you on the case for this @thienlnam ?

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2024
@thienlnam
Copy link
Contributor

Ah, I created one here #36196 (comment)

Wait.. you're assigned to it as well 😆
I'll close this one so we can consolidate there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants