[$2000] Android- PDF Scrolling Issue: Difficulty in Navigating Through Pages

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1 Initiate a chat with another user
2 Go to + > add attachment >choose document > upload a multipage pdf file
3 Open the pdf file and scroll down and up
4 Verify if its smooth
5 Now, upload an image
6 Go back to the pdf file and try to scroll up-down
7 Verify if the image opens (Next image is selected when swiping the screen up and down)

Expected Result:

Smooth interaction with pdf. No difficulty in scrolling pdf pages

Actual Result:

Difficulty in scrolling through pdf. Sometimes another document opens instead of scrolling

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-07-22.at.1.21.12.AM.mp4

az_recorder_20230723_101401.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690006696574999

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ef34bf6d94d34d3b
• Upwork Job ID: 1686884315196669952
• Last Price Increase: 2023-10-18
• Automatic offers:
• HezekielT | Contributor | 27284015
• avi-shek-jha | Reporter | 27284018

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ShogunFire]

Might be related to this PR : #21714

[johncschuster]

Thanks for the callout, @ShogunFire!

[melvin-bot]

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

@kavimuru the above-linked issue and PR has been closed. Can you please try reproducing the reported behavior in this issue to see if it persists?

[avi-shek-jha]

@johncschuster Hi, I reported this one and since, I was free today so I took the time to retest it. The problem still persists. I tested it on the latest build of Android v1.3.48-5.

WhatsApp.Video.2023-08-01.at.7.58.16.PM.mp4

[johncschuster]

Ok cool. Thanks for confirming!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ef34bf6d94d34d3b

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[jaylalakiya]

This is happening because of scrolling conflict between FlatList and Pdf component by react-native-pdf package.
We have horizontal FlatList of attachments and if particular attachment is pdf, we are rendering it using Pdf component by react-native-pdf package. When user tries to scroll pdf, scroll event of parent FlatList also gets triggered in case of android (wonday/react-native-pdf#448, wonday/react-native-pdf#693 and many more issues related to scrolling on android in this package).

We should disable horizontal FlatList scrolling when pdf is being scrolled vertically. But according to my research, there is no default way of getting callback for scroll related events from react-native-pdf package ([https://github.com/wonday/react-native-pdf]).

Waiting for senior's reply to move further.

[melvin-bot]

@johncschuster @mollfpr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mollfpr]

This is happening because of scrolling conflict between FlatList and Pdf component by react-native-pdf package.

@jaylalakiya That might be correct, but I don't have much context since I can't test sending attachments in the latest main. If you have another solution, please submit a proposal, and I'll gladly review it. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

@mollfpr what do you think? It seems like we should raise the bounty.

[melvin-bot]

📣 @avi-shek-jha 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[avi-shek-jha]

Hello, This issue was reported on July 23 before the new changes took place. Can someone please send me the corrected offer as I received the one for 50 dollars instead of 250 for older issues?

[mollfpr]

@HezekielT Let me know when the PR is ready because Melvin will not request my review. Thank you!

@avi-shek-jha I think @johncschuster will take care of that.

[HezekielT]

@mollfpr PR is ready for review.

[johncschuster]

@avi-shek-jha, I've adjusted your offer to account for the previous Bug Reporter amount. Thanks for calling that out!

[avi-shek-jha]

@avi-shek-jha, I've adjusted your offer to account for the previous Bug Reporter amount. Thanks for calling that out!

Thank you John. Accepted.

[melvin-bot]

@johncschuster, @Gonals, @mollfpr, @HezekielT Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@johncschuster, @Gonals, @mollfpr, @HezekielT 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@johncschuster, @Gonals, @mollfpr, @HezekielT Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@johncschuster, @Gonals, @mollfpr, @HezekielT 12 days overdue. Walking. Toward. The. Light...

[mollfpr]

Not overdue. The PR is merged.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[johncschuster]

Oh boy, I literally just paid this out too 😅.

@Gonals, I'll follow your lead on this one.

[melvin-bot]

This issue has not been updated in over 15 days. @johncschuster, @Gonals, @mollfpr, @HezekielT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mollfpr]

@johncschuster I think this was ready for payment. Could you give the payment summary to make a manual request? Thanks!

[mollfpr]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. This difference in behavior between Android and iOS is causing the issue.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open any report
2. Click on + of the composer.
3. Select Add attachment > Choose document > upload a multi-page pdf file.
4. Open the pdf file and scroll up and down.
5. Verify the scroll is smooth.
6. Close the attachment and Click on + of the composer again.
7. Upload an image.
8. Open the image and swipe to the left.
9. Verify the previously sent pdf is opened.
10. Scroll through the pdf up and down.
11. Verify the scroll is smooth.

---

Friendly bump @johncschuster

[mollfpr]

Friendly bump @johncschuster

[mollfpr]

Friendly bump @johncschuster

[johncschuster]

Payment Summary

Bug reporter @avi-shek-jha - $250 - PAID via Upwork ✅
Contributor that fixed the issue: @HezekielT - $2000 - PAID via Upwork ✅
C+ that reviewed the issue: @mollfpr - $2000 - needs to be paid via manual request

[JmillsExpensify]

$2,000 payment approved for @mollfpr based on summary above.