[$1000] Web - Routing number field for new workspace is populated with value from deleted workspace.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Create a workspace.
3. Go to Bank Account
4. Update currency to USD on popup.
5. Click on 'connect manually'.
6. Enter a routing number.
7. Now instead of clicking on continue, go back and delete that workspace.
8. Create a workspace again.
9. Go to Bank account and change currency to USD.
10. Go to 'connect manually'

Expected Result:

The routing number field should be empty.

Actual Result:

Routing number field is populated with routing number value which we had entered in our deleted workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-23.at.3.44.12.PM.mov

Recording.3872.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mehvash-Khan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690113213055829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012d45e1d746eb489a
• Upwork Job ID: 1683580182181593088
2023-07-24
• Automatic offers:
• samh-nl | Contributor | 25818185

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Routing number field for new workspace is populated with value from deleted workspace.

What is the root cause of that problem?

We didn't clear the bank account data while deleting a workspace which cause the issue.

What changes do you think we should make in order to solve the problem?

I think that make senses to keep bank account data if we still have workspaces since we shared the bankAccount data between workspace, we should only clear it when we don't have any workspace. So we can add a useEffect inside our WorkspacesListPage if our policies are empty then clear the bankAccount data.

    React.useEffect(() => {
        if (_.isEmpty(policies)) {
            // clear bank account data with BankAccounts.resetFreePlanBankAccount(bankAccountID)}
        }
    }, [policies]);

What alternative solutions did you explore? (Optional)

N/A

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A new workspace is populated with routing number field of a deleted workspace.

What is the root cause of that problem?

The bank account form data is re-used between workspaces:

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Lines 82 to 83 in 82669ae

	<Form
	formID={ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM}

What changes do you think we should make in order to solve the problem?

We can append the workspace ID to the Onyx key to ensure the data does not spill over.

What alternative solutions did you explore? (Optional)

Alternatively, upon deleting the (last) workspace we can clear the information.

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A new workspace is populated with routing number field of a deleted workspace.

What is the root cause of that problem?

The bank account form data is re-used between all workspaces because we use same inputID

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Lines 95 to 107 in 80ac696

	<TextInput
	autoFocus
	shouldDelayFocus={shouldDelayFocus}
	inputID="routingNumber"
	label={translate('bankAccount.routingNumber')}
	accessibilityLabel={translate('bankAccount.routingNumber')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	defaultValue={props.getDefaultStateForField('routingNumber', '')}
	keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
	disabled={shouldDisableInputs}
	shouldSaveDraft
	shouldUseDefaultValue={shouldDisableInputs}
	/>

What changes do you think we should make in order to solve the problem?

We can get policyID as props from ReimbursementAccountPage -> BankAccountStep -> BankAccountManualStep.
And we can use different inputID between workspaces

inputID={`${props.policyID}-routingNumber`}
defaultValue={props.getDefaultStateForField(`${props.policyID}-routingNumber`, '')}

In this case, input will be clear on new workspace and we can use other values between workspace

What alternative solutions did you explore? (Optional)

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Clarifying https://expensify.slack.com/archives/C049HHMV9SM/p1690226439537099?thread_ts=1690113213.055829&cid=C049HHMV9SM

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012d45e1d746eb489a

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

[parasharrajat]

Still discussing...

[parasharrajat]

Given that there are no objections and one plus vote with a good reason to move forward, I think we should change this.

[parasharrajat]

@samh-nl 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@samh-nl 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

AFAIK, we're sharing bank account information between workspaces. If you already completed 4 steps, when you created a new one, and press connect bank account you can start from step 4 instead of starting from over again.
Why don't we just clear the data when there's no workspace instead of giving each of them difference draft values?

[parasharrajat]

Good point. I moved based on the Slack discussion. Free to share your points there.

[melvin-bot]

📣 @samh-nl 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @mehvash-Khan We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[mehvash-Khan]

I have applied to the Upwork job. Thanks.

[samh-nl]

The policyID would have to be appended to reimbursementAccount Onyx data returned from the backend also to separate them out per workspace.

[parasharrajat]

Ok, Sure. I will review this on the PR.

[parasharrajat]

PR has more than expected changes. It was my mistake that I didn't think it through during the proposal review. At this stage, I feel like we need to discuss this again. we are touching mostly everything related to policies in the app and there can be unexpected bugs with these changes. It has been bothering me and I couldn't move ahead with the PR.

I am going to ask for opinions on Slack or ask for helping hands.

[samh-nl]

@parasharrajat Understandable, for anyone that would like to get involved, this comment in the PR may be useful (see "High-level summary of changes" and "Requested backend change").

[mehvash-Khan]

Hi @parasharrajat , Is this issue open for more proposals? Can I add a proposal?

[parasharrajat]

@mehvash-Khan Currently, it is assigned to a contributor. Rest, I live it up to you.

[jasperhuangg]

we are touching mostly everything related to policies in the app and there can be unexpected bugs with these changes

@parasharrajat Can you outline what changes introduced in the PR might cause bugs with policies?

Otherwise, I mostly agree with your feedback. I'm realizing that bank accounts aren't stored with policies in the back-end, so it actually may not make much sense to start associating with them policies. We may be able to implement a simpler, front-end only solution that solves this issue.

Sorry for the back and forth! @samh-nl

[samh-nl]

Any update? Thanks. Merging does become increasingly difficult over time, so might be good to give some priority on deciding what the best way forward is.

[jasperhuangg]

@samh-nl I'm honestly starting to think we can just do nothing here. I don't think this particular bug is extremely detrimental to user experience. I'm not really sure if it's worth considering this a bug at all, it could even be considered a feature that your bank account information is saved between workspaces. I'm going to go ahead and close this out.

[samh-nl]

Fair enough. I will comfort myself with the thought that if this ever gets implemented, the work done might save people some time and it wasn't completely in vain.

[samh-nl]

Just curious as I recently saw a closed issue was being compensated due to this passage in the contributors guide:

Compensation is only guaranteed to those who propose a solution and get hired for that job.

Anything that can be done in this case? Thanks a lot.

[hungvu193]

Just curious as I recently saw a closed issue was being compensated due to this passage in the contributors guide:

Compensation is only guaranteed to those who propose a solution and get hired for that job.

Anything that can be done in this case? Thanks a lot.

hey can you raise a slack discussion for that? I'm running into a similar case.

[parasharrajat]

@kevinksullivan Can you please look into the above request #23480 (comment)?

[kevinksullivan]

asking in slack

https://expensify.slack.com/archives/C01SKUP7QR0/p1694789498641489

[parasharrajat]

Any results @kevinksullivan ?

[kevinksullivan]

We only pay when someone has done the work, sorry for any confusion here.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.