Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page #23539

Closed
2 of 6 tasks
kbecciv opened this issue Jul 25, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open a new account
  2. Click on FAB > Assign task > Give it a title > Click next
  3. Click on share somewhere > paste something into the input field > confirm it pastes correctly
  4. Reload the page while in the share somewhere page
  5. Try to paste text inside the text input field

Expected Result:

Text should be pasted inside the input field

Actual Result:

Unable to paste text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.45-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-07-25.12.10.16.mp4
Recording.3889.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690276386534669

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 25, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro
Copy link
Contributor

This is a regression of some PR, but I don't think this is a deploy blocker since it's a super edge case, almost no one would try to paste after reloading the new task page.

@pecanoro
Copy link
Contributor

Found the PR that caused the regression (#23135), I tested it with and without and it's working with the old changes.

@mountiny
Copy link
Contributor

mountiny commented Jul 25, 2023

@pecanoro there is a Pr up with a follow up, confirming if it solves the issue.

#23525

@pecanoro
Copy link
Contributor

@mountiny Yeah, if the root cause is the same, we should close this one as it's the same bug.

@mountiny
Copy link
Contributor

The other issue is not a deploy blocker then, we should keep one deploy blocker open until fix is CPed

@mountiny
Copy link
Contributor

The PR fixes this too so I will add this issue to the PR body and add reviewing label

@mountiny mountiny added the Reviewing Has a PR in review label Jul 25, 2023
@pecanoro
Copy link
Contributor

Awesome, thank you so much!!

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jul 26, 2023
@melvin-bot melvin-bot bot changed the title Task - Unable paste from clipboard on share somewhere page after reloading the page [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page Jul 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 27, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Task - Unable paste from clipboard on share somewhere page after reloading the page Jul 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 1, 2023
@pecanoro
Copy link
Contributor

pecanoro commented Aug 4, 2023

Hmm this was a duplicate of #23502 and #23537 and we agreed to close it.

@pecanoro pecanoro closed this as completed Aug 4, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants