[HOLD for c+ newdot payment][$1000] Compose box loses focus when reclicking same chat in LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Notice that the composer is focused
3. Click on the same chat in LHN. Notice the composer loses focus

Expected Result:

Compose box don't lose focus when Clicking on the same chat in LHN

Actual Result:

Compose box loses focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test87.Composerlosefocus-1.mp4

Recording.1360.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690317170412039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a795f9206baa2f0c
• Upwork Job ID: 1684464091337949184
• Last Price Increase: 2023-08-07
2023-07-27
• Automatic offers:
• daveSeife | Reporter | 25800239
• tienifr | Contributor | 26045509

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App loses focus from compose box on clicking same chat in LHN for the 2nd time

What is the root cause of that problem?

This issue has been fixed previously in #21552 where we prevent opening Report page when re-clicking the active report. Here we retrieved the currentReportID using withCurrentReportID HOC.

App/src/pages/home/sidebar/SidebarLinks.js

Lines 148 to 158 in 5ffd4e6

	showReportPage(option) {
	// Prevent opening Report page when clicking LHN row quickly after clicking FAB icon
	// or when clicking the active LHN row
	// or when continuously clicking different LHNs, only apply to small screen
	// since getTopmostReportId always returns on other devices
	if (this.props.isCreateMenuOpen || this.props.currentReportID === option.reportID || (this.props.isSmallScreenWidth && Navigation.getTopmostReportId())) {
	return;
	}
	Navigation.navigate(ROUTES.getReportRoute(option.reportID));
	this.props.onLinkClick();
	}

However after the major refactor in #21406, withCurrentReportID HOC was lifted up to the parent component SidebarLinksData to optimize performance. Unfortunately, the author might have forgotten about the above mentioned line where we relied on currentReportID. Thus it will always be undefined.

What changes do you think we should make in order to solve the problem?

Lift the check this.props.currentReportID === option.reportID up to SidebarLinksData as a callback:

const isActiveReport = useCallback((option) => currentReportID === option.reportID, [currentReportID]);

Declare proper prop types for SidebarLinks and pass the callback to it.

Update: For the callback, in order not to use currentReportID as a dependency of the callback, which leads to the callback re-render too often, we should save it in a ref instead and update it in a useEffect. We already have a usePrevious for that.

const prevCurrentReportID = usePrevious(currentReportID);
const isActiveReport = useCallback((option) => prevCurrentReportID === option.reportID, [prevCurrentReportID]);

[kadiealexander]

Repro:

2023-07-27_19-21-06.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a795f9206baa2f0c

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[Santhosh-Sellavel]

@mountiny @hannojg @0xmiroslav Check this proposal. This is a regression from #21406, please take care.

[0xmiros]

I can take care

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @0xmiroslav You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@kadiealexander, @Santhosh-Sellavel, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kadiealexander]

@0xmiroslav @Santhosh-Sellavel any updates?

[0xmiros]

There's 1 proposal pending review. I will provide feedback tomorrow.

[hannojg]

Checking …

[hannojg]

Every time the current report page would change, the callback would change, and thus the SidebarLinks would re-render as well. The effect would be the same as just passing currentReportID

Here is what we could do instead:

[hannojg]

We can save the currentReportID in a ref (and update the ref from a useEffect).
Then we create a memoized callback as @tienifr pointed out (minor note: I'd only pass a string as parameter).

For this part

We can save the currentReportID in a ref (and update the ref from a useEffect).

we already have a hook called usePrevious. The full solution would roughly look like this:

function SidebarLinksData({currentReportID}) {
  const currentReportIDRef = usePrevious(currentReportID);
  const isReportActive = useCallback((reportID) => 
     reportID === currentReportIDRef.current,
  // 👀 Notice how the useCallback has no dependency now and thus it reference will stay the same!
  []);

  return (
    <SidebarLinks {...} isReportActive={isReportActive} />
   );
}

@tienifr Feel free to use that to update your proposal 😊

[tienifr]

Thanks a lot @hannojg for your suggestion! I tested again and updated my proposal.

[kadiealexander]

Thanks @Santhosh-Sellavel!! I can't reproduce anymore, can you?

[tienifr]

@kadiealexander I've explained in the PR about why we should proceed even though the issue is no longer reproducible.

[kadiealexander]

Thanks @tienifr!!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @tienifr got assigned: 2023-08-10 08:38:26 Z
• when the PR got merged: 2023-09-06 07:30:47 UTC
• days elapsed: 18

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.65-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Composer does not refocus when click the same chat #24360

If no regressions arise, payment will be issued on 2023-09-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MonilBhavsar]

Bumping to weekly

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: [Fix #21022] Improve performance by reducing re-renders SidebarLinks #21406
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Fix #21022] Improve performance by reducing re-renders SidebarLinks #21406 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. https://expensify.slack.com/archives/C049HHMV9SM/p1695055888894839
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. We should already have this on other issue
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

@kadiealexander Please leave a payment summary here.

[kadiealexander]

Payouts due:

• Issue Reporter: $250 @daveSeife
• Contributor: $1000 @tienifr
• Contributor+: $1000 @Santhosh-Sellavel

Eligible for 50% #urgency bonus? No

Upwork job is here.

[Santhosh-Sellavel]

Requested on ND

[kadiealexander]

Not overdue.

[Santhosh-Sellavel]

I got paid lets close this one, thanks!