[HOLD for payment 2023-09-18] [$500] Web - App triggers Pay button for request money on selection of emoji

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open user B report
3. From another device, send request money request from user B to user A
4. Open emoji picker from user A device and search for any emoji
5. Press enter to select the emoji and observe that along with emoji selection, app also approves the request money request

Expected Result:

App should not approve request money on selection of emoji from emoji picker

Actual Result:

App approves request money on selection of emoji from emoji picker

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

selecting.emoji.triggers.pay.in.chat.mp4

Recording.3974.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690539769279639

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019246b5e6c84e3e9d
• Upwork Job ID: 1697646674207739904
• Last Price Increase: 2023-09-01
• Automatic offers:
• Ollyws | Reviewer | 26516786
• huzaifa-99 | Contributor | 26516787
• dhanashree-sawant | Reporter | 26516788

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the request money action to not get approved when we press enter key, it doesn't matter if we press enter inside the emoji picker input or in other places of the app.

What is the root cause of that problem?

We are passing pressOnEnter to the button in ButtonWithDropDownMenu. Which will listen for enter key press and will submit the money request button.

What changes do you think we should make in order to solve the problem?

I think for money request actions we should not approve them on enter key press. We can remove the pressOnEnter here or pass it conditionally via a new prop (that ButtonWithDropdownMenu will receive)

What alternative solutions did you explore? (Optional)

N/A

[kbecciv]

Only reproduced with public account, not expensifail

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[muttmuure]

Wow this is really weird

[melvin-bot]

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[muttmuure]

Can't reproduce this one.

[dhanashree-sawant]

Hi @muttmuure, I could still reproduce on latest staging, can you let me know what do you see after trying to recreate? maybe I can help

[huzaifa-99]

This is still reproducible, following these steps

1. Login with 2 users
2. From User A request money from User B
3. From User B, open the chat and make sure you blur any input that is focused (you can click on the 'Expensify' icon for this)
4. Now Press enter and notice the money request gets paid.

@kbecciv mentioned here, that it is only reproduced with public accounts.

mrp.paid.mp4

cc: @muttmuure

[luacmartins]

This is still happening and can be easily reproducible using a public domain account, e.g. @gmail.com

[muttmuure]

I wasn't able to reproduce it myself

[muttmuure]

Seems kinda sporadic

[muttmuure]

If you can reproduce it then I'll just go ahead and add external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019246b5e6c84e3e9d

[luacmartins]

@Ollyws could you please complete the BZ checklist above?

[muttmuure]

Offers updated

[muttmuure]

Just waiting for everyone to accept

[huzaifa-99]

@muttmuure just confirming if the offer is for $500?

Update: I see issue was created before the compensation changes.

[dhanashree-sawant]

Thanks @muttmuure, I have accepted the offer.

[Ollyws]

@muttmuure I've been offered $1000, this one is only $500 I think.

[muttmuure]

It was created before August 30th so the offers are $1000

[muttmuure]

Paid @huzaifa-99 and @dhanashree-sawant

[muttmuure]

Just waiting for @Ollyws

[huzaifa-99]

@muttmuure Thanks for the payments.

Can I request the 3-day merge bonus? The PR was C+ Reviewed on the same PR creation day (Sep 6 Wednesday) and was merged by the internal engineer on Sep 11, Monday. Also, there was a merge freeze that ended on Sep 11, Monday. I am happy either way, just wanted to bring this up. Thank you!

[Ollyws]

@muttmuure Offer accepted, thanks.

[luacmartins]

Still working through payments

[melvin-bot]

@Ollyws, @luacmartins, @muttmuure, @huzaifa-99 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Looks like this is eligible for bonuses after all, I will apply those now

[muttmuure]

bonuses paid out

[muttmuure]

@Ollyws do we need a regression test for this?

[Ollyws]

Yeah I think a regression test would be good here because it's an important flow and could result in a user sending money by accident.

[Ollyws]

Regression Test Proposal

1. Login with 2 users
2. Request Money from User B to User A
3. From User A, open the chat with User B, make sure you see the IOUPreview message with a Pay button.
4. Click on any blank text on the screen Ex: the Expensify logo, and press enter. Verify that pressing enter does not submit the money request report.
5. Open the emoji picker, and search for any emoji. 
6. While the focus is on text input, press enter to select the searched emoji. Verify that pressing enter when selecting the emoji does not submit the money request report.

Do we agree 👍 or 👎

[luacmartins]

Sounds good to me

[muttmuure]

https://github.com/Expensify/Expensify/issues/324583 regression test requested