[HOLD for payment 2023-10-16] [$250] Regression: prop 'value' of type 'string' supplied to 'CheckboxWithLabel', expected 'boolean`

[hannojg]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

In this PR a change was added to fix several regressions, however it created a new regression with checkboxes in forms:

#22589

Expected Result:

There should be no console error

Actual Result:

A console error is showing when interacting with a checkbox wrapped in a Form:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

It's an error only devs will see + it doesn't have any impact on the functionality of the app.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:1.3.47-5
Reproducible in staging?:no (not deployed yet)
Reproducible in production?:no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: See in Actual result
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690578654439359?thread_ts=1690578654.439359&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140a93db1203e631c
• Upwork Job ID: 1709884954347847680
• Last Price Increase: 2023-10-05

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hannojg]

PR for fixing it is up:

• [NoQA] Check for boolean input values #23910

[sobitneupane]

@hannojg Can you please add the reproduction steps? I was unable to reproduce the issue.

[Pujan92]

@sobitneupane to reproduce you can do a fresh login and open any workspace bank account manual setup as reimbursementAccountDraft won't be there in the onyxDB at the moment which makes the warning in console.

[dhairyasenjaliya]

The easiest way to reproduce this is just hard refresh the app (iOS), navigate to Add payment page, and then just select Debit card The console error should appear right on this page @sobitneupane

[sobitneupane]

Thanks @Pujan92 and @dhairyasenjaliya.

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140a93db1203e631c

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Check for boolean input values #23910

If no regressions arise, payment will be issued on 2023-10-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)
• @sobitneupane does not require payment (Eligible for Manual Requests)
• @dhairyasenjaliya requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 @sobitneupane checklist time, thanks!

[melvin-bot]

@trjExpensify, @hannojg, @sobitneupane, @mountiny Huh... This is 4 days overdue. Who can take care of this?

[trjExpensify]

Same, awaiting checklist.

[sobitneupane]

@trjExpensify Sorry for the delay. I was OOO. I will try to get it done in the weekend.

[trjExpensify]

Thanks, @sobitneupane. Did you get to it?

In the meantime, confirming payments we'll issue as follows:

• @dhairyasenjaliya $50 for the bug report
• @sobitneupane $250 for the C+ review

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#22589

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

Not Required.

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It should have been caught in PR review.

• [@sobitneupane] Determine if we should create a regression test for this bug.

The issue is reproducible only in Dev. So, regression test is not required.

[trjExpensify]

Thanks, @sobitneupane!

It should have been caught in PR review.

If that's the case, is there something in the reviewer checklist that could be improved such that it is caught?

[sobitneupane]

The change was made in Form component which affects all the components using Form. And we already have a point in reviewer checklist to verify it.

If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App

[sobitneupane]

#23909 (comment)

Requested payment on newDot.

[trjExpensify]

@dhairyasenjaliya an offer has been sent to you.

[dhairyasenjaliya]

accepted thnx @trjExpensify

[trjExpensify]

Cool, paid. Closing!

[JmillsExpensify]

$250 payment approved for @sobitneupane based on this comment.