[WAITING ON EUGENE] [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) #23933

kavimuru · 2023-07-31T16:13:22Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open the app
Ensure that app language is English
Click on plus and click on request money / split bill
Add any amount, try to insert ',' (comma) in 2nd last or 3rd last position, app doesn't insert a cursor but jumps positions
Try to insert any other symbol like '=,+,|,?' in 2nd last or 3rd last position and app won't allow the symbol to insert but will keep the cursor position same
Switch to Spanish language mode.
Try to insert '.' (period) in 2nd last or 3rd last position and observe that app will jump the cursor one position ahead every time if the language is set to Spanish

Expected Result:

App should not change cursor position when we try to insert ',' in amount for English language OR '.' in amount for Spanish language in request money / split bill

Actual Result:

App changes cursor position when we try to insert ',' in amount for English language OR '.' in amount for Spanish language in request money / split bill

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

cursor.position.jump.on.fullstop.or.comma.mp4

Recording.1412.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690268210124929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b976c4c3347bca34
Upwork Job ID: 1686553611490000896
Last Price Increase: 2023-08-09
Automatic offers:

samh-nl | Contributor | 26109224
dhanashree-sawant | Reporter | 26109226

melvin-bot · 2023-07-31T16:13:27Z

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-31T16:13:30Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

samh-nl · 2023-07-31T16:38:19Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cursor jumps to next position when we use ',' in request money when language is English

What is the root cause of that problem?

We are updating the cursor position using the non-comma stripped amount and subsequently strip the comma from the amount.
Therefore, the new cursor position is based on the incorrect (longer) value, leading it to jump to the next position.

App/src/pages/iou/steps/MoneyRequestAmountPage.js

Lines 315 to 318 in 0fb8709

    
           setAmount((prevAmount) => { 
        
               setSelection((prevSelection) => getNewSelection(prevSelection, prevAmount.length, newAmountWithoutSpaces.length)); 
        
               return stripCommaFromAmount(newAmountWithoutSpaces); 
        
           });

What changes do you think we should make in order to solve the problem?

We should use the stripped amount for updating the cursor position, e.g.:

...
const strippedAmount = stripCommaFromAmount(newAmountWithoutSpaces);
setSelection((prevSelection) => getNewSelection(prevSelection, prevAmount.length, strippedAmount.length));
return strippedAmount;
...

This also fixes it for the Spanish scenario.

What alternative solutions did you explore? (Optional)

Ignoring event default behavior if the key is pressed, however this would require adding an extra handler.

jliexpensify · 2023-08-01T01:27:23Z

@kavimuru can you re-test on v1.3.48-0? I can't seem to enter a comma when requesting money or splitting a bill.

samh-nl · 2023-08-01T09:05:24Z

@jliexpensify I've reproduced it on staging (v1.3.48-0). There are constraints to this bug, for example the cursor must not be placed at the beginning of the amount.

jliexpensify · 2023-08-01T22:39:46Z

@samh-nl can you share a video? I can't get a cursor to show at all on my end :(

I'm on v1.3.48-4

kavimuru · 2023-08-02T01:31:25Z

@jliexpensify Here is the video.

Recording.1425.mp4

jliexpensify · 2023-08-02T01:43:20Z

Thanks, that video helps - I've edited the GH issue and can repro.

melvin-bot · 2023-08-02T01:44:52Z

Job added to Upwork: https://www.upwork.com/jobs/~01b976c4c3347bca34

melvin-bot · 2023-08-02T01:44:55Z

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-02T01:45:01Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

melvin-bot · 2023-08-02T03:19:23Z

📣 @servesh-chaturvedi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot · 2023-08-02T04:49:03Z

📣 @Surojd! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Surojd · 2023-08-02T05:26:25Z

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/surojd

melvin-bot · 2023-08-02T05:26:28Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Surojd · 2023-08-02T05:28:43Z

Proposal

Please re-state the problem that we are trying to solve in this issue.
Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish)

What is the root cause of that problem?

The non-comma-stripped amount is used to update the cursor location before the comma is removed.
Because of this, the new cursor location is determined by the wrong (longer) value, causing it to advance to the following point.

[App/src/pages/iou/steps/MoneyRequestAmountPage.js](https://github.com/Expensify/App/src/pages/iou/steps/MoneyRequestAmountPage.js#L315-L318


 setAmount((prevAmount) => { 
     setSelection((prevSelection) => getNewSelection(prevSelection, prevAmount.length, newAmountWithoutSpaces.length)); 
     return stripCommaFromAmount(newAmountWithoutSpaces); 
 });

What changes do you think we should make in order to solve the problem?

We should use the stripped amount for updating the cursor position, e.g.:

 const strippedAmount = stripCommaFromAmount(newAmountWithoutSpaces);
setSelection((prevSelection) => getNewSelection(prevSelection, prevAmount.length, strippedAmount.length));
return strippedAmount;

This also fixes it for the Spanish scenario.

What alternative solutions did you explore? (Optional)

N/A

Proof Video

02.08.2023_10.24.48_REC.mp4

Crystalian0322 · 2023-08-03T09:20:32Z

Proposal
Please re-state the problem that we are trying to solve in this issue.
Cursor jumps to next position when we use ',' in request money when language is English
https://github.com/Expensify/App/blob/ac49271c4009af1555f2513a11a7313831ae1961/src/pages/ReportDetailsPage.js#L18C1-L23C47
What is the root cause of that problem?
We are updating the cursor position using the non-comma stripped amount and subsequently strip the comma from the amount.
Therefore, the new cursor position is based on the incorrect (longer) value, leading it to jump to the next position.

https://github.com/Expensify/App/blob/157abce51a8ba4c1b7a82a596dcc6686b82be76d/src/pages/home/ReportScreen.js#L10C1-L19C3

What changes do you think we should make in order to solve the problem?
We should use the stripped amount for updating the cursor position, e.g.:

...
const strippedAmount = stripCommaFromAmount(newAmountWithoutSpaces);
setSelection((prevSelection) => getNewSelection(prevSelection, prevAmount.length, strippedAmount.length));
return strippedAmount;
...
This also fixes it for the Spanish scenario.

What alternative solutions did you explore? (Optional)
Ignoring event default behavior if the key is pressed, however this would require adding an extra handler.

jliexpensify · 2023-08-06T23:06:33Z

Bump @0xmiroslav - there are a few proposals to review!

melvin-bot · 2023-08-21T09:57:15Z

@danieldoglas @eVoloshchak @jliexpensify @samh-nl this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

danieldoglas · 2023-08-21T15:19:21Z

What would you recommend for testing mobile, use the keys present on the number pad?

If in mobile we can't see those, it's ok to show just our custom number pad and that it works normally.

samh-nl · 2023-08-21T21:26:32Z

PR is ready for review: #25624

melvin-bot · 2023-08-24T22:21:16Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @samh-nl got assigned: 2023-08-14 09:47:46 Z
when the PR got merged: 2023-08-24 22:21:15 UTC
days elapsed: 8

On to the next one 🚀

melvin-bot · 2023-08-30T01:07:33Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-08-30T01:07:37Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: use stripped amount for new selection #25624

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@eVoloshchak does not require payment (Eligible for Manual Requests)
@samh-nl requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-30T01:07:39Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eVoloshchak] Determine if we should create a regression test for this bug.
[@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

jliexpensify · 2023-09-06T02:37:19Z

Payment summary:

Bug Reporter: @dhanashree-sawant $250
Contributor: @samh-nl $1000
C+: @eVoloshchak $1000 (New.Dot payment)

Upwork job

@eVoloshchak can you complete the checklist? Thanks!

jliexpensify · 2023-09-07T02:34:40Z

Bumping @eVoloshchak to complete the checklist please!

jliexpensify · 2023-09-08T02:00:03Z

Paid in Upoworks, job removed. @eVoloshchak friendly bump to complete the checklist before we issue you payment, thanks!

eVoloshchak · 2023-09-08T06:14:53Z

The PR that introduced the bug has been identified. Link to the PR: Refactor/23149 money request page #23979
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23979/files#r1319408939
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It's a fairly simple bug, I don't think an additional discussion is necessary

eVoloshchak · 2023-09-08T06:17:58Z

Regression Test Proposal

Click on the FAB -> Request money
Enter 10.00
Move the cursor near the start
Press comma and dot (web/desktop) or press the comma/dot in the number pad (mobile)
Verify that the cursor does not move
Go to Settings > Preferences > Language and change language to Spanish
Click on the FAB
Click on Request money
Enter 10,00
Move the cursor near the start
Press comma and dot (web/desktop) or press the comma/dot in the number pad (mobile)
Verify that the cursor does not move

Do we agree 👍 or 👎

JmillsExpensify · 2023-09-10T10:14:44Z

Reviewed the details for @eVoloshchak. $1,000 approved for payment via NewDot based on BZ summary.

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 31, 2023

melvin-bot bot assigned jliexpensify Jul 31, 2023

kavimuru changed the title ~~Cursor jumps to next position when we use ',' in request money when language is english~~ Cursor jumps to next position when we use ',' in request money when language is English Jul 31, 2023

jliexpensify changed the title ~~Cursor jumps to next position when we use ',' in request money when language is English~~ [WAITING ON KAVI] Cursor jumps to next position when we use ',' in request money when language is English Aug 1, 2023

jliexpensify changed the title ~~[WAITING ON KAVI] Cursor jumps to next position when we use ',' in request money when language is English~~ Cursor jumps to next position when we use ',' in request money when language is English Aug 2, 2023

jliexpensify changed the title ~~Cursor jumps to next position when we use ',' in request money when language is English~~ Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) Aug 2, 2023

jliexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 2, 2023

melvin-bot bot changed the title ~~Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish)~~ [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) Aug 2, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 2, 2023

melvin-bot bot assigned 0xmiros Aug 2, 2023

melvin-bot bot added the Overdue label Aug 4, 2023

melvin-bot bot added the Engineering label Aug 21, 2023

samh-nl mentioned this issue Aug 21, 2023

fix: use stripped amount for new selection #25624

Merged

59 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 21, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 30, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Aug 30, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 5, 2023

eVoloshchak mentioned this issue Sep 8, 2023

Refactor/23149 money request page #23979

Merged

56 tasks

melvin-bot bot added the Overdue label Sep 10, 2023

jliexpensify closed this as completed Sep 10, 2023

melvin-bot bot removed the Overdue label Sep 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WAITING ON EUGENE] [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) #23933

[WAITING ON EUGENE] [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) #23933

kavimuru commented Jul 31, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023 •

edited by jliexpensify

Loading

samh-nl commented Jul 31, 2023 •

edited

Loading

jliexpensify commented Aug 1, 2023

samh-nl commented Aug 1, 2023

jliexpensify commented Aug 1, 2023 •

edited

Loading

kavimuru commented Aug 2, 2023

jliexpensify commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

Surojd commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

Surojd commented Aug 2, 2023

Crystalian0322 commented Aug 3, 2023 •

edited

Loading

jliexpensify commented Aug 6, 2023

melvin-bot bot commented Aug 21, 2023

danieldoglas commented Aug 21, 2023

samh-nl commented Aug 21, 2023

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

jliexpensify commented Sep 6, 2023

jliexpensify commented Sep 7, 2023

jliexpensify commented Sep 8, 2023

eVoloshchak commented Sep 8, 2023

eVoloshchak commented Sep 8, 2023

JmillsExpensify commented Sep 10, 2023

[WAITING ON EUGENE] [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) #23933

[WAITING ON EUGENE] [$1000] Cursor jumps to next position when we use ',' in request money when language is English (or if using '.' in Spanish) #23933

Comments

kavimuru commented Jul 31, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023 • edited by jliexpensify Loading

Bug0 Triage Checklist (Main S/O)

samh-nl commented Jul 31, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

jliexpensify commented Aug 1, 2023

samh-nl commented Aug 1, 2023

jliexpensify commented Aug 1, 2023 • edited Loading

kavimuru commented Aug 2, 2023

jliexpensify commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

Surojd commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

Surojd commented Aug 2, 2023

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proof Video

Crystalian0322 commented Aug 3, 2023 • edited Loading

jliexpensify commented Aug 6, 2023

melvin-bot bot commented Aug 21, 2023

danieldoglas commented Aug 21, 2023

samh-nl commented Aug 21, 2023

melvin-bot bot commented Aug 24, 2023

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

melvin-bot bot commented Aug 30, 2023

jliexpensify commented Sep 6, 2023

jliexpensify commented Sep 7, 2023

jliexpensify commented Sep 8, 2023

eVoloshchak commented Sep 8, 2023

eVoloshchak commented Sep 8, 2023

JmillsExpensify commented Sep 10, 2023

kavimuru commented Jul 31, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 31, 2023 •

edited by jliexpensify

Loading

samh-nl commented Jul 31, 2023 •

edited

Loading

jliexpensify commented Aug 1, 2023 •

edited

Loading

Crystalian0322 commented Aug 3, 2023 •

edited

Loading