Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD E#326093] [$1000] Chat inconsistency between User A and User B after a Request money #24042

Closed
1 of 6 tasks
kavimuru opened this issue Aug 2, 2023 · 51 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Aug 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. user A login
  2. user A creates a money request for user B
  3. user B login
  4. user B pays request money from user A
  5. user A writes a message in the IOU thread with user B, click send
  6. user B cannot see the message
  7. user B must exit the chat and enter again to be able to see the message sent by user A

Expected Result:

both users should be able to see chat messages the moment they are sent

Actual Result:

both users cannot see the chat messages at the time they are sent, one of the users must exit the chat to update

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.49-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-08-01.at.22.24.23.mp4
Compartir.pantalla.-.2023-08-01.22_03_22.mp4
Recording.1427.mp4

Expensify/Expensify Issue URL:
Issue reported by: @eusalazar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690939247360729

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0106ee6101f89ce228
  • Upwork Job ID: 1691926490954178560
  • Last Price Increase: 2023-08-23
Issue OwnerCurrent Issue Owner: @flodnv
Issue OwnerCurrent Issue Owner: @flodnv
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Aug 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 7, 2023

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

@johncschuster
Copy link
Contributor

I haven't gotten to testing this behavior. I'll work on it this afternoon.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 9, 2023
@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Aug 16, 2023
@melvin-bot melvin-bot bot changed the title Chat inconsistency between User A and User B after a Request money [$1000] Chat inconsistency between User A and User B after a Request money Aug 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0106ee6101f89ce228

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@johncschuster
Copy link
Contributor

Commenting to get Melvin to chill out with the Overdue label.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 16, 2023
@Piotrfj
Copy link
Contributor

Piotrfj commented Aug 21, 2023

Hey, I'm Piotr from Callstack - expert contributor group - I would like to help resolve this issue

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

📣 @Piotrfj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

@johncschuster, @eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

@Piotrfj
Copy link
Contributor

Piotrfj commented Aug 22, 2023

Update: I was able to reproduce the issue. Seems like it could be backend issue, I've checked in websocket and there were no events to add new report.

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

@johncschuster @eVoloshchak this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

@johncschuster, @eVoloshchak 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

@johncschuster, @eVoloshchak 10 days overdue. Is anyone even seeing these? Hello?

@johncschuster
Copy link
Contributor

@eVoloshchak do you agree with @Piotrfj that this could be a backend issue? If so, I'll make this internal.

@flodnv
Copy link
Contributor

flodnv commented Sep 29, 2023

I can confirm I was able to reproduce this

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@johncschuster
Copy link
Contributor

Nice one, @flodnv!

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@johncschuster
Copy link
Contributor

No update here

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2023
@johncschuster johncschuster added the Daily KSv2 label Oct 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@flodnv, @johncschuster, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@flodnv
Copy link
Contributor

flodnv commented Oct 24, 2023

No updates, still focusing on higher priority strategic projects.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2023
@flodnv flodnv removed the Daily KSv2 label Oct 26, 2023
@johncschuster
Copy link
Contributor

Thanks for the update, @flodnv! Should we downgrade the label on this one?

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2023
@flodnv
Copy link
Contributor

flodnv commented Oct 27, 2023

I did that but you undid that last week 😄

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@flodnv
Copy link
Contributor

flodnv commented Nov 6, 2023

Still no update for now.

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@flodnv
Copy link
Contributor

flodnv commented Nov 13, 2023

Sorry for the delay. Turns out user B will never receive the pusher update, does not matter how many message there are in the IOU thread, the backend was never sending it, so I fixed that 🙃 PR is in review...

@flodnv flodnv added the Reviewing Has a PR in review label Nov 13, 2023
@mountiny
Copy link
Contributor

I will put this on hold for internal issue https://github.com/Expensify/Expensify/issues/326093

@mountiny mountiny changed the title [$1000] Chat inconsistency between User A and User B after a Request money [HOLD E#326093] [$1000] Chat inconsistency between User A and User B after a Request money Nov 15, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 7, 2023
Copy link

melvin-bot bot commented Dec 7, 2023

This issue has not been updated in over 15 days. @flodnv, @johncschuster, @eVoloshchak eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@flodnv, @johncschuster, @eVoloshchak, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants