-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for PR #18997] Chat - Infinite loading after opening attached image a few times #24067
Comments
Triggered auto assignment to @garrettmknight ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.When image attachment is opened several times in Native apps, sometimes the loading icon is shown forever and the image preview does not load. What is the root cause of that problem?In see: App/src/components/ImageView/index.native.js Lines 225 to 226 in 2f750ad
That works well when it is the first time the image is being opened, However, when an image is being opened more than once, it is already cached, so technically the image does not need to be loaded anymore, What changes do you think we should make in order to solve the problem?We actually do not need to configure App/src/components/ImageView/index.native.js Lines 63 to 68 in 2f750ad
To resolve the issue, we should unset App/src/components/ImageView/index.native.js Line 225 in 2f750ad
What alternative solutions did you explore? (Optional)If the indeterministic firing sequence of |
might be same root cause #22920 |
@gadhiyamanan agreed, I think this looks like the same root cause. Let's put this on hold and leave this open until this PR is deployed. I'll retest and see if that fixed it. |
Still holding |
Still holding |
Still holding |
Still holding |
Still holding |
Still holding on #18997 |
Still holding on #18997 |
Still holding on #18997 |
Still holding |
Still holding on #18997 |
Still holding on #18997 |
Still holding on #18997 |
1 similar comment
Still holding on #18997 |
Still holding on #18997 |
Still holding on #18997 |
I'm just going to close this. It'll come back up if ti matters |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The image preview is shown every time
Actual Result:
Infinite loading after opening the image preview a few times. The same behavior when opening images from old chats
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.49.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6150602_Video_2023-08-02_12-10-52-1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: