[C+ Checklist Needs Completion] [$500] App triggers mention results after '!' and allows to select value but after sending, displays the email as link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any text and end with exclamation point and write @ after it to trigger mention results eg: 'Hello!@'
4. Select any value and send the message
5. Observe that in message, it is displayed as email link even though while sending, app displayed it as mention and allowed us to select any value

Expected Result:

App should not trigger mention results if text has no space before @

Actual Result:

App triggers mention results right after '!' (exclaimation) and after selecting and sending message, displays the email as email link

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.50.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mention.displayed.as.email.link.mp4

Recording.5764.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690906004615859

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a7e78f93955508d
• Upwork Job ID: 1701232379675463680
• Last Price Increase: 2023-09-18
• Automatic offers:
• akamefi202 | Contributor | 26812390
• dhanashree-sawant | Reporter | 26812392

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[greg-schroeder]

I don't know about this as a "bug" tbh

[greg-schroeder]

Actually, I believe this will be fixed by #17387 so perhaps we hold for that

[greg-schroeder]

Holding

[greg-schroeder]

""

[greg-schroeder]

""

[dhanashree-sawant]

Hi @greg-schroeder, hold issue is deployed to live and following issue is still reproducible on latest staging.

[greg-schroeder]

Okay, removing the hold

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a7e78f93955508d

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update spilt regex to fix suggestions issue  #28045

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akamefi202 requires payment offer (Contributor)
• @thesahindia does not require payment (Eligible for Manual Requests)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Hi there, can we check to see if this is a regression? #28753 (comment)

[akamefi202]

@puneetlath @greg-schroeder @thesahindia
Can we complete this issue if there isn't any other problem?
I think #28753 is not bug after all so this issue is not a regression.

[greg-schroeder]

Sorry for delay, was OOO. Processing today.

[akamefi202]

bump @greg-schroeder

[greg-schroeder]

Reporter: @dhanashree-sawant ($250)
Contributor: @akamefi202 ($750)
C+: @thesahindia ($750)

@thesahindia you can make a manual request

[thesahindia]

It was an edge case. I think we should skip the checklist. There were too many changes and it wasn't possible to prevent.

We can add a test case -

1. Open any report
2. Enter !@ in the composer
3. Verify that you don't get any suggestions

[greg-schroeder]

Sounds good, thanks @thesahindia

[akamefi202]

@greg-schroeder @thesahindia Could you plz pay the bonus and finish the contract on Upwork?

[greg-schroeder]

this is done

[akamefi202]

Thank you, everyone!

[JmillsExpensify]

$750 payment approved for @thesahindia based on this comment.