Web - Workspace - "More" tooltip is displayed when hovering over the three dots after clicking on them

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings and click on "Create workspace"
2. Click on the three dots in the top right corner to open the details
3. Hover over the three dots again
4. Notice that the "More" tooltip is displayed again

Expected Result:

After opening the details, hovering over the three dots should not display the "More" tooltip again and the Cursor should be Changed

Actual Result:

After opening the details, hovering over the three dots displays the "More" tooltip again.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.51-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.1136.mp4

screen-capture.-.2023-08-08T062550.532.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691501020584879

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

Confirmed I can only reproduce this on staging

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Workspace - "More" tooltip is displayed when hovering over the three dots after clicking on them

What is the root cause of that problem?

We are not hiding the tooltip when popover is open.

What changes do you think we should make in order to solve the problem?

Pass another prop to toolTip
here

App/src/components/ThreeDotsMenu/index.js

Line 88 in c70a619

<Tooltip text={this.props.translate(this.props.iconTooltip)}>

shouldDisplay={!this.state.isPopupMenuVisible}

and then in Tooltip conditionally render it
{this.state.isRendered && this.props.shouldDisplay &&(
<TooltipRenderedOnPageBody

What alternative solutions did you explore? (Optional)

We can also hide tooltip by passing prop isPopupMenuVisible

[puneetlath]

I don't think this needs to be a deploy blocker. It also seems similar to #24284

[puneetlath]

I think the fact that it still show the tooltip when you re-hover is fine. The FAB also does that. I think instead the problem is that re-clicking on it doesn't do anything.

[samueltuyizere]

I agree @puneetlath , may be clicking on it again should hide the dropdown.

[melvin-bot]

📣 @samueltuyizere! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[samueltuyizere]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0143489d2cddff3bbd

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[hungvu193]

Proposal

I agree with Puneet, that we should hide the modal if we click three dot again.

Please re-state the problem that we are trying to solve in this issue.

Threedot button does nothing when popup is already visible.

What is the root cause of that problem?

In our onPress function of threedot icon, we only have logic of showing it here:

App/src/components/ThreeDotsMenu/index.js

Lines 91 to 94 in 0f83752

	this.showPopoverMenu();
	if (this.props.onIconPress) {
	this.props.onIconPress();
	}

That's why once it opened and we clicked threedot icon, we won't see anything happened.

What changes do you think we should make in order to solve the problem?

We can change this to:

    onPress={() => {
        if (this.state.isPopupMenuVisible) {
            this.hidePopoverMenu();
        } else {
            this.showPopoverMenu();
        }
        
        if (this.props.onIconPress) {
            this.props.onIconPress();
        }
    }}

What alternative solutions did you explore? (Optional)

N/A

[aimane-chnaif]

Dupe of #24296

[tewodrosGirmaA]

@aimane-chnaif, I would like to bring to your attention that I have previously reported an issue regarding confusion in creating GitHub issues. Kindly refer to the following Slack conversation for further details: https://expensify.slack.com/archives/C049HHMV9SM/p1691501020584879."

[aimane-chnaif]

@tewodrosGirmaA we already planned to fix as a follow-up, so no bug reporting bonus here.
Original bug report while working on PR: #19011 (comment)
Please read full discussions on #15289 (comment)

[tewodrosGirmaA]

@aimane-chnaif , this is not fair , just without any reason, I reported first

[aimane-chnaif]

@aimane-chnaif , this is not fair , just without any reason, I reported first

Huh? How come you can report bug even if PR was not merged yet?

[tewodrosGirmaA]

@aimane-chnaif , this is not fair , just without any reason, I reported first

Huh? How come you can report bug even if PR was not merged yet?

That is my magic hhhh , I mean I reported first before this #24296,

[aimane-chnaif]

Original bug report while working on PR: #19011 (comment)

@tewodrosGirmaA saying again, it's firstly reported by QA team while PR testing before merge.
And we discuss this out of scope and planned to fix separately.

@zanyrenney let's close this as dupe

[AndrewGable]

Closing as dupe