Incorrect page is showing even there is error in bank connect flow

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Start connect bank flow, do everything till step 3 fine, Save and continue.
2. Close the modal & open the flow again by click Continue with the step.
3. Observe you're landed and Step 3 which is correct, now navigate back to 2nd step and do type random invalid email which returns backend error.https://hahjajhahjahja.assssss.a.s.s.ss.a.s.ssssssass.asssshja.chjahjahahjhjajhha.hjahjahjahjahjahjahja.hahjahjjahjahjaahjahjhja.hjahjahjahjaahjahj.hjahjahjahjahjaahjahj.hjahjahjahjaahj.hjajhahjaajhahjahjahjahjahjahjahjahjahjahjaahjahjaasshjsjhshjsh/jshjshj.chjahjshjshjshjshjshj.hjahjahshjshjshjshjshjshjshjshjshjs.ahjshjshjshjshjshjshjs.hjahjahjs[hjshjshjshjshjshjshjhjshjshjshjshjshjshjshjshjshjshjhjshjshjahj.com/](http://hjshjshjshjshjshjshjhjshjshjshjshjshjshjshjshjshjshjhjshjshjahj.com/)
4. Observe that data save failed & you're stuck at step.
5. Close the modal & restart the flow again by click Continue Over step and observe it takes to step 3 instead of step 2

Expected Result:

Flow should be take us to the correct step if any failed validations there when updating.

Actual Result:

Taking to the wrong page even having wrong details.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Kapture.2023-08-02.at.02.31.20.1.mp4

2023-08-07.19.24.46.mp4

Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690924062828829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cf0cacf8a882b35c
• Upwork Job ID: 1690903425450983424
• Last Price Increase: 2023-08-28

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[daordonez11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

An incorrect step is shown in ReimbursementAccountPage when continue is pressed and there was an error in a different step

What is the root cause of that problem?

To show the current step the method fetchData is called and the step is calculated using achData.currentStep. Since this variable is not changing when there is an error it just shows the "last" step that was worked in this case RequestorStep instead of CompanyStep, where it fails.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 258 to 269 in b8119e9

	fetchData(ignoreLocalCurrentStep) {
	// Show loader right away, as optimisticData might be set only later in case multiple calls are in the queue
	BankAccounts.setReimbursementAccountLoading(true);
	// We can specify a step to navigate to by using route params when the component mounts.
	// We want to use the same stepToOpen variable when the network state changes because we can be redirected to a different step when the account refreshes.
	const stepToOpen = this.getStepToOpenFromRouteParams();
	const achData = lodashGet(this.props.reimbursementAccount, 'achData', {});
	const subStep = achData.subStep || '';
	const localCurrentStep = achData.currentStep || '';
	BankAccounts.openReimbursementAccountPage(stepToOpen, subStep, ignoreLocalCurrentStep ? '' : localCurrentStep);
	}

What changes do you think we should make in order to solve the problem?

When there is an issue in the validation or in the submit of the form in CompanyStep or basically in any step of the configuration we should reset achData.currentStep to the step that failed.

reimbursementAccount is stored in the onyx key REIMBURSEMENT_ACCOUNT so we could call a service that refreshes the current step in backend or merge manually updating currentStep with CONST.BANK_ACCOUNT.STEP.COMPANY

What alternative solutions did you explore? (Optional)

[hungvu193]

So I reported this long time ago, and it was decided to close:
#14107
More information:
#14107 (comment)

[b4s36t4]

@hungvu193 i think this is valid because the issue you mentioned does have validation in front end itself but the validation error is coming here if from backend.

[hungvu193]

@hungvu193 i think this is valid because the issue you mentioned does have validation in front end itself but the validation error is coming here if from backend.

Oh, I see what you mean.

[jliexpensify]

Hi @b4s36t4 - I'm not an engineer but can you explain to me the difference between what @hungvu193 has shared and this issue? Specifically the front-end vs back-end - if the other issues have been closed, why would this one (which seems to be a similar issue) be considered a bug? Thanks!

[daordonez11]

@jliexpensify basically in the steps of the ticket mentioned what is discussed is about the information that is in the form but they say that since it hasn't been validated there is nothing to do. The difference with this ticket is that here it is validated, it does fail when you try to save and continue(Step 4), hence, the server should be able to store the "failed" step. That is the difference between both tickets. So probably this might be half internal because achData is stored in the server but since we know in the front-end something failed in the form the server should update that as well.

cc @hungvu193 Let me know if I missed something else

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cf0cacf8a882b35c

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[jliexpensify]

Ok, awesome - thanks @daordonez11! @allroundexperts could you review this comment and share your thoughts on whether this needs to be brought internally? It sounds like it could go either way. Thanks!

[jliexpensify]

Bump @allroundexperts !

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@allroundexperts @jliexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@allroundexperts, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Bumping @allroundexperts for an update!

[jliexpensify]

Not overdue - @grgia should this be a Monthly?

[grgia]

Yes, making monthly for now

[jliexpensify]

Not overdue, removed the Weekly label

[jliexpensify]

Not overdue

[grgia]

not prioritizing currently

[jliexpensify]

Not overdue!

[jliexpensify]

Hi @grgia - this came up in my list of issues to assign to a Project/VIP: I can't work out where it fits in. Hoping you can help?

[jliexpensify]

Heya @grgia - just bumping this one!

p.s. I'm OOO from 21st to 31st March

[jliexpensify]

Alrighty, chatted to @grgia via DM and since this is internal and very low priority, we're going to close it for focus on roadmap issues. Thanks!

[b4s36t4]

@jliexpensify Wouldn't I qualify for the reporting bonus?

[jliexpensify]

Hi @b4s36t4 thanks for the bump, I'll re-open this and get you paid for $250.

[jliexpensify]

@b4s36t4 invited you here

[b4s36t4]

Done, thanks!

[jliexpensify]

Job removed.