Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-08-10 #24388

Closed
45 tasks done
OSBotify opened this issue Aug 10, 2023 · 12 comments
Closed
45 tasks done

Deploy Checklist: New Expensify 2023-08-10 #24388

OSBotify opened this issue Aug 10, 2023 · 12 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Aug 10, 2023

Release Version: 1.3.53-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@puneetlath puneetlath self-assigned this Aug 10, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 10, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.53-1 🚀

@amyevans
Copy link
Contributor

Checked off #24423, it's not a blocker

@Li357
Copy link
Contributor

Li357 commented Aug 11, 2023

Checked off #24419, not a blocker

@puneetlath
Copy link
Contributor

Checking off #24311 and #24326. The fixes have been CP'd.

@puneetlath
Copy link
Contributor

Checking off #24430 based on this comment: #24430 (comment)

@mvtglobally
Copy link

Regression is completed

#24039 is failing #23572. Repro in prod

#24222 is failing #22959, repro in prod

#24206 pending validation on all platforms.

@luacmartins
Copy link
Contributor

Checking off #24490, since that happens in production

@puneetlath
Copy link
Contributor

Checking off #24424 since the fix was CP'd.

@mvtglobally
Copy link

Can you pls also validate #24206 internally as we don't have gold wallets and may not be able to check all the features

@yuwenmemon yuwenmemon self-assigned this Aug 14, 2023
@yuwenmemon
Copy link
Contributor

Validated #24206 internally - checking it off.

@yuwenmemon
Copy link
Contributor

Checking off the other two since it looks like the fixes for those are in review and the problems are already on prod.

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants