-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: compose box becomes overlapped by the keyboard #24502
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hey @mananjadhav, I was officially assigned to this issue. It is ready for review. |
Yes I'll be reviewing this today. |
Checked the change, but because it is inside |
I've added it to the EDIT: Going to make some changes |
@mananjadhav I couldn't have enough time to test it thoroughly, will make additional tests tomorrow. |
Update: |
@mananjadhav friendly reminder, it is ready for a review :) |
Yes I’ll be testing this today. |
did some basic testing on Web, but I am not receiving magic codes on mweb. I'll check this on mobile safari physical device. |
Hey @mananjadhav, do you have any update? Do the magic codes work again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code works fine, and I did basic other sanity on the Composer too, and it looks to be working fine.
Reviewer Checklist
Screenshots/VideosWebweb-composer-scroll.movMobile Web - Chromemweb-chrome-composer-scroll.movMobile Web - Safarimweb-safari-composer-scroll.mp4Desktopdesktop-composer-scroll.moviOSios-composer-scroll.movAndroidandroid-composer-scroll.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great but there are some merge conflicts now @kosmydel. Please message me on NewDot when they are fixed and I'll merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but unfortunately we have a merge freeze now.
Hey @neil-marcellini, I believe that the merge freeze has ended! |
@kosmydel Can you merge the latest main? |
I'm holding off on merging this because the deploy checklist is quite large right now and we don't want to overwhelm things. |
Merged & tested it quickly. |
I've tested this again, @neil-marcellini can we merge this and push to the next deploy list? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.72-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀
|
Details
Fixed Issues
$ #23986
PROPOSAL: #23986 (comment)
Tests
Offline tests
Doesn't affect network-related behavior.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mweb-android.mov
Mobile Web - Safari
mweb-ios.mov
Desktop
desktop.mov
iOS
ios.mp4
Android
android.mov