[HOLD for payment 2023-09-20] [$1000] Web - Profile - No back button on personal details offline mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. If logged in then logout
3. Login and switch off internet connection
4. Visit settings->profile->personal details and observe that page does not have back button while loading

Expected Result:

App should display back button on personal details page while loading on offline mode

Actual Result:

App does not display back button on personal details page while loading on offline mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.54-11

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

no.back.personal.details.offline.mode.mp4

Recording.1228.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691391806874729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012444d83c2a13626a
• Upwork Job ID: 1692462598974083072
• Last Price Increase: 2023-08-25
• Automatic offers:
• huzaifa-99 | Contributor | 26416409
• Dhanashree-Sawant | Reporter | 26416410

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to show the back button when the data for the personal details page is loading.

What is the root cause of that problem?

When the data for personal details page is loading we only show the loading indicator here, instead of also showing the header and back button.

What changes do you think we should make in order to solve the problem?

We can update the ScrollView here to conditionally render, i.e only if we have loaded the personal details data, otherwise we show the loading indicator

{lodashGet(props.privatePersonalDetails, 'isLoading', true) ?
    <FullscreenLoadingIndicator /> :
    <ScrollView>
        {/*. other code .... */}
    </ScrollView>
}

The FullscreenLoadingIndicator adds an absolute fill which looks like this (notice the header)

To fix this we have to update some styles, we can follow either of these options after applying the above change

1. update the styles of FullscreenLoadingIndicator to only fill the available width/height (instead of absolute), replacing StyleSheet.absoluteFillObject with styles.w100, styles.h100
2. pass a zIndex to <HeaderWithBackButton/> that is greater than the zIndex of FullscreenLoadingIndicator
3. Pass styles.flex1, styles.pRelative to the FullscreenLoadingIndicator, same as like we do here

Optional:
There are a lot of other places that have the same issue, we can fix all those in the same go.

What alternative solutions did you explore? (Optional)

N/A

[sonialiap]

Triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012444d83c2a13626a

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Profile - No back button on personal details offline mode

What is the root cause of that problem?

App/src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js

Lines 86 to 88 in c435734

	if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

If the data is loading, we are only show FullscreenLoadingIndicator

What changes do you think we should make in order to solve the problem?

The same problem happen on: LegalNamePage, DateOfBirthPage, AddressPage

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

Lines 69 to 71 in 6319e59

	if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

App/src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js

Lines 63 to 65 in 6319e59

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Lines 134 to 136 in 6319e59

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

I suggest that we should create new HOC called WithPrivatePersonalDetailsyAndFullscreenLoading like we did in WithPolicyAndFullscreenLoading
And using this HOC for all above places

What alternative solutions did you explore? (Optional)

We can update like this in all above places

{lodashGet(props.privatePersonalDetails, 'isLoading', true) 
            ? <FullscreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
             : <ScrollView>
                    ....
             </ScrollView>
}

Result

[ArekChr]

@DylanDylann What is the difference between implementation WithPolicyAndFullscreenLoading and WithPrivatePersonalDetailsyAndFullscreenLoading? Can we use one HOC for that? Both uses FullscreenLoadingIndicator

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No back button appears in personal details page in offline mode

What is the root cause of that problem?

As you can see below, we show FullscreenLoadingIndicator whe private personal details is loading. This component has no back button

App/src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js

Lines 86 to 88 in 6319e59

	if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to move the FullscreenLoadingIndicator below the HeaderWithBackButton component

        {lodashGet(props.privatePersonalDetails, 'isLoading', true) ? (
            <View style={[styles.pRelative, styles.flex1]}>
                <FullscreenLoadingIndicator />
            </View>
        ) : (
            <ScrollView>
                ...
            </ScrollView>
        )}

Wrapping by View would prevent the full page getting dark

This issue exists on other pages as well. Those should be fixed.

Result

What alternative solutions did you explore? (Optional)

We can add the wrapper props to the FullscreenLoadingIndicator as follows

function FullScreenLoadingIndicator(props) {
    const additionalStyles = _.isArray(props.style) ? props.style : [props.style];
    const content = (
        <View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading, ...additionalStyles]}>
            <ActivityIndicator
                color={themeColors.spinner}
                size="large"
            />
        </View>
    );

    return props.wrapper ? (
        <View style={[styles.pRelative, styles.flex1]}>
            {content}
        </View>
    ) : content;
}

[blazejkustra]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We aim to display the back button while the personal details page is loading data

What is the root cause of that problem?

The problem arises when the data for the personal details page is being loaded; during this time, we only display the loading indicator here. As a result, the back button is not being shown.

What changes do you think we should make in order to solve the problem?

Extract HeaderWithBackButton component to a variable and reuse it in the loading logic here along with FullscreenLoadingIndicator with additional styles.

Before:

if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
    return <FullscreenLoadingIndicator />;
}

After:

const headerWithBackButton = (
    <HeaderWithBackButton
        title={props.translate('privatePersonalDetails.personalDetails')}
        onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PROFILE)}
    />
);

if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
    return (
        <ScreenWrapper>
            {headerWithBackButton}
            <FullscreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />
        </ScreenWrapper>
    );
}

☝️ This makes the component much more readable as the 'loading state' of component has its own return statement.

Also change the usage of HeaderWithBackButton in the final return statement here.

Before:

<HeaderWithBackButton
    title={props.translate('privatePersonalDetails.personalDetails')}
    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PROFILE)}
/>

After:

{headerWithBackButton}

Optional: Do the same in other similar places as well.

What alternative solutions did you explore? (Optional)

N/A

Result

[huzaifa-99]

@ArekChr Did you get a chance to look at my proposal here

[lucentdevteam]

Hello There,

Please find my solution here

Technical explanation

1. Implement the "onLine" property from the Navigator interface in the browser to determine the online status.
2. Display the "ScrollView" exclusively when the connection is online; otherwise, present a loading spinner or an offline symbol.
3. The required modifications should be made in the file named PersonalDetailsInitialPage.js.

Looking forward to hearing from you.

[melvin-bot]

📣 @lucentdevteam! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lucentdevteam]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/niteshlucentinnovation

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[lucentdevteam]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/niteshlucentinnovation

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[lucentdevteam]

Hello There,

Please find my solution here

Technical explanation

1. Implement the "onLine" property from the Navigator interface in the browser to determine the online status.
2. Display the "ScrollView" exclusively when the connection is online; otherwise, present a loading spinner or an offline symbol.
3. The required modifications should be made in the file named PersonalDetailsInitialPage.js.

Looking forward to hearing from you.

Thanks

[lucentdevteam]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[$1000] Web - Profile - No back button on personal details offline mode #24642 - Expensify

What is the root cause of that problem?

The error is because of this code
if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) {
return ;
}

What changes do you think we should make in order to solve the problem?

Move the FullscreenLoadingIndicator to above ScrollView tag and below HeaderWithBackButton .

What alternative solutions did you explore? (Optional)

• Implement the "onLine" property from the Navigator interface in the browser to determine the online status.
• Display the "ScrollView" exclusively when the connection is online; otherwise, present a loading spinner or an offline symbol.

[DylanDylann]

@ArekChr The difference between implementation WithPolicyAndFullscreenLoading and WithPrivatePersonalDetailsyAndFullscreenLoading is the prop we use to check if we should show loading screen or not.
In WithPolicyAndFullscreenLoading we use this condition to show loading screen

if (props.isLoadingReportData && _.isEmpty(props.policy)) {
            return <FullscreenLoadingIndicator />;
        }

In WithPrivatePersonalDetailsyAndFullscreenLoading we use another prop to check

 if (lodashGet(props.privatePersonalDetails, 'isLoading', true)) { 
     return <FullscreenLoadingIndicator />; 
 } 

[melvin-bot]

📣 @huzaifa-99 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[huzaifa-99]

Thanks for the review guys, PR will be ready shortly

[huzaifa-99]

PR #26346 is ready for review @ArekChr @aldo-expensify

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @huzaifa-99 got assigned: 2023-08-30 17:17:03 Z
• when the PR got merged: 2023-09-11 13:23:56 UTC
• days elapsed: 7

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[huzaifa-99]

This is not a regression/deploy-blocker, more context here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show header in profile pages when personal details are loading #26346

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @huzaifa-99 requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ArekChr] Determine if we should create a regression test for this bug.
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ArekChr]

• Link to the PR: No bug identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

[Christinadobrzyn]

@huzaifa-99 can you accept the Upwork offer here - #24642 (comment)

[huzaifa-99]

Accepted, Thanks @Christinadobrzyn

[sonialiap]

@ArekChr does not require payment (Contractor)
@huzaifa-99 fix + bonus = $1500 - paid ✔️
@dhanashree-sawant reporter $250 - paid ✔️

Aug 31 5:41
Sep 1 1:59

[dhanashree-sawant]

Hi @sonialiap, the offer on upwork is still pending for approval, can you check once you are available?