[HOLD for payment 2023-12-08] [TS migration] Migrate 'models' lib to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/libs/models/BankAccount.js	5

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fvlvte]

I am Kacper Fałat from Callstack - expert contributor group. I'd like to work on this job

[melvin-bot]

📣 @fvlvte! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fabioh8010]

Hey @mountiny Could we assign a engineer to take a look at the PR? It got approved by C+ but the engineer was not assigned. Thanks!

[situchan]

Let me try 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[fabioh8010]

Thanks @situchan ❤️

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][TS migration] Migrate 'models' lib to TypeScript #27667

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

@neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

[neil-marcellini]

Closing this out since I don't think payment is needed.

[thesahindia]

Closing this out since I don't think payment is needed.

Hey @neil-marcellini. Actually payment for C+ review is due. I reviewed the PR.

Can you please add a payment summary here? I will need to get the money request approved on New Dot. I think it's $250 for TS migration tickets.

[JmillsExpensify]

Need a payment summary before I can approve the payment for @thesahindia. cc @neil-marcellini

[JmillsExpensify]

Still waiting on a payment summary.

[neil-marcellini]

Payment summary:
Please pay @thesahindia $250 for the PR review.

[JmillsExpensify]

$250 payment approved for @thesahindia based on comment above.