Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-12] [TS migration] Migrate 'LocalNotification' lib to TypeScript #24905

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/Notification/LocalNotification/index.website.js 1
src/libs/Notification/LocalNotification/index.native.js 0
src/libs/Notification/LocalNotification/index.desktop.js 1
src/libs/Notification/LocalNotification/BrowserNotifications.js 6
src/libs/Notification/LocalNotification/focusApp/index.website.js 0
src/libs/Notification/LocalNotification/focusApp/index.desktop.js 1
Issue OwnerCurrent Issue Owner: @MitchExpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 30, 2023
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed Not a priority labels Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

mountiny commented Dec 4, 2023

$250 to @fedirjh once deployed with no regressions

Copy link
Author

melvin-bot bot commented Dec 12, 2023

@kubabutkiewicz, @mountiny, @MitchExpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny changed the title [TS migration] Migrate 'LocalNotification' lib to TypeScript [HOLD for payment 2023-12-12] [TS migration] Migrate 'LocalNotification' lib to TypeScript Dec 12, 2023
@mountiny mountiny added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Dec 12, 2023
@mountiny
Copy link
Contributor

issue was linked incorrectly, this is ready for payment @MitchExpensify

@MitchExpensify
Copy link
Contributor

Payment issue created for you here and invited @fedirjh https://www.upwork.com/jobs/~01c91332994586a049

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2023
@Garretrein
Copy link

Hi, My name is David, As a Full stack software engineer, i am interested of this issue.
I quite sure that i can resolve this issue.

Copy link
Author

melvin-bot bot commented Dec 12, 2023

📣 @Garretrein! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@fedirjh
Copy link
Contributor

fedirjh commented Dec 12, 2023

@MitchExpensify Thank you. Accepted.

@Davnbrown
Copy link

Hello, My name is David Brown.
https://www.upwork.com/freelancers/~01459846037723f7ae

Copy link
Author

melvin-bot bot commented Dec 12, 2023

📣 @Davnbrown! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@MitchExpensify
Copy link
Contributor

Paid and contract ended!

@Davnbrown
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01459846037723f7ae

Copy link
Author

melvin-bot bot commented Dec 13, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Davnbrown
Copy link

now how can I do?

@fedirjh
Copy link
Contributor

fedirjh commented Dec 13, 2023

@Davnbrown This issue was already addressed. Please check other open issues (open jobs), please make sure to read the contributing Guides. Thank you!

@MitchExpensify
Copy link
Contributor

Apologies for any confusion, no help needed here @Davnbrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

6 participants