[HOLD for payment 2023-12-07] [TS migration] Migrate 'Navigation' lib to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/libs/Navigation/navigationRef.js	1
src/libs/Navigation/linkingConfig.js	4
src/libs/Navigation/linkTo.js	6
src/libs/Navigation/getTopmostReportId.js	2
src/libs/Navigation/getStateFromPath.js	2
src/libs/Navigation/OnyxTabNavigator.js	6
src/libs/Navigation/NavigationRoot.js	13
src/libs/Navigation/Navigation.js	14
src/libs/Navigation/FreezeWrapper.js	5

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[blazejkustra]

Hey! I’m Blazej from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[situchan]

Getting engineer for PR review 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[flodnv]

@roryabraham I assigned you as per #31543 (comment)

[fabioh8010]

@blazejkustra Could you check if your PR is covering all files described in this list? I believe it is, but just want to confirm 🙂

Updated List

Files

Path	Dependencies
src/libs/Navigation/navigationRef.js	1
src/libs/Navigation/linkingConfig.js	4
src/libs/Navigation/linkTo.js	7
src/libs/Navigation/getTopmostReportId.js	2
src/libs/Navigation/getTopmostReportActionID.js	2
src/libs/Navigation/getStateFromPath.js	2
src/libs/Navigation/OnyxTabNavigator.js	6
src/libs/Navigation/NavigationRoot.js	13
src/libs/Navigation/Navigation.js	15
src/libs/Navigation/FreezeWrapper.js	6
src/libs/Navigation/shouldPreventDeeplinkPrompt/index.js	1

[blazejkustra]

@fabioh8010 Yep, it does!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'Navigation' lib to TypeScript #31543

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[situchan]

@flodnv can you please reopen and add Bug label for eventual payment? Thanks

[flodnv]

Sure, sorry about that, I got confused because in some of these we don't issue payments

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[flodnv]

@abekkala ignore melvin-bot, AFAIK all we need to do is If no regressions arise, payment will be issued on 2023-12-07. to @situchan (someone please correct me if I'm wrong)

[abekkala]

@flodnv Can I confirm that this is a $250 PR review payment as this is a TS migration?

[situchan]

yes correct. But the PR was very large. #24934 (comment) also proves it. Can we adjust amount based on that?

[flodnv]

Alright, we can do $500 as an exception 👍

[abekkala]

@situchan offer was sent in Upwork.

Once accepted I can submit payment! 🎉

[abekkala]

@situchan payment sent and contract ended - thank you! 🎉