Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2024-01-11] [TS migration] Migrate 'useKeyboardState.js' hook to TypeScript #24941

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/hooks/useKeyboardState.js 2
Issue OwnerCurrent Issue Owner: @zanyrenney
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013420d481d1cddf89
  • Upwork Job ID: 1745415455470731264
  • Last Price Increase: 2024-01-11
  • Automatic offers:
    • situchan | Contributor | 28094547
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@fvlvte
Copy link
Contributor

fvlvte commented Oct 10, 2023

I am Kacper Fałat from Callstack - expert contributor group

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny
Copy link
Contributor

Going to take over since Lucien is ooo

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 4, 2024
Copy link
Author

melvin-bot bot commented Jan 5, 2024

@mountiny
Copy link
Contributor

mountiny commented Jan 5, 2024

$250 to @situchan

@parasharrajat parasharrajat moved this from Todo to Done in Typescript migration Jan 9, 2024
@zanyrenney
Copy link
Contributor

cool, today is the day! working on the payment now.

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Jan 11, 2024
Copy link
Author

melvin-bot bot commented Jan 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013420d481d1cddf89

@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-11] [TS migration] Migrate 'useKeyboardState.js' hook to TypeScript [$500] [HOLD for payment 2024-01-11] [TS migration] Migrate 'useKeyboardState.js' hook to TypeScript Jan 11, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 11, 2024
Copy link
Author

melvin-bot bot commented Jan 11, 2024

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 11, 2024
@zanyrenney
Copy link
Contributor

using external to create job.

@zanyrenney
Copy link
Contributor

@situchan
Copy link
Contributor

@zanyrenney I haven't got offer yet. Can you please unassign and assign me back? It will send offer automatically.

@zanyrenney zanyrenney assigned situchan and unassigned situchan Jan 11, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 11, 2024
@zanyrenney
Copy link
Contributor

done, let me know if it came through okay @situchan ?

@Expensify Expensify deleted a comment from melvin-bot bot Jan 11, 2024
@zanyrenney
Copy link
Contributor

2024-01-11_12-08-52
definitely is sent successfully @situchan

@situchan
Copy link
Contributor

you can update issue title to [$250]

@situchan
Copy link
Contributor

I got Melvin offer, but not yours

@zanyrenney
Copy link
Contributor

hmm melvin offer is for the wrong amount though. the payment is @250 not 500.

@zanyrenney
Copy link
Contributor

when i try to amend the offer to reflect the correct price i get this error:
2024-01-11_12-11-12

hang tight whilst i investigate please @situchan

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Jan 11, 2024
@zanyrenney
Copy link
Contributor

offer succesffully sent @situchan please accept for payout! 🎉

@zanyrenney
Copy link
Contributor

Payment summary
$250 to @situchan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants