Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-17] [TS migration] Migrate 'useKeyboardShortcut.js' hook to TypeScript #24942

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 6 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/hooks/useKeyboardShortcut.js 2
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 Weekly KSv2 labels Nov 7, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'useKeyboardShortcut.js' hook to TypeScript [HOLD for payment 2023-11-17] [TS migration] Migrate 'useKeyboardShortcut.js' hook to TypeScript Nov 10, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 10, 2023
Copy link
Author

melvin-bot bot commented Nov 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@parasharrajat parasharrajat moved this from Todo to In Progress in Typescript migration Jan 9, 2024
Copy link
Author

melvin-bot bot commented Feb 16, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

1 participant