[HOLD for payment 2023-10-30] [TS migration] Migrate 'withCurrentUserPersonalDetails.js' HOC to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/withCurrentUserPersonalDetails.js	6

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] [TS migration] Migrate 'withCurrentUserPersonalDetails.js' HOC to TypeScript #29547

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[dangrous]

Adding you here @Ollyws so we can get you sorted on a review payment

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

@Christinadobrzyn not a bug but getting you on here for payment on 10/30 when we're ready!

[dangrous]

Not overdue, waiting for payment

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the NewFeature assigner, not assigning anyone new.

[roryabraham]

@dangrous this would be a good case for the NewFeature label instead of a Bug. That will help ensure that the payment is coded as R&D instead of CoR

[dangrous]

ooh okay - does that still assign BZ?

[Christinadobrzyn]

This is so confusing, I'm not really sure who worked on this or who I'm paying.

@dangrous Can I get a review of this payment structure to make sure it's right?

Payouts due:

Issue Reporter: NA
Contributor: $250 @VickyStash (Contractor - not paid through Upwork/NewExpensify)
Contributor+: $250 @Ollyws (paid in Upwork)

Eligible for 50% #urgency bonus? NA - new feature

Upwork job is here.

[dangrous]

I believe that is correct! So the only action required is @Ollyws's payment for review.

[Ollyws]

Are the TS PRs not only $250?

[Christinadobrzyn]

Oh! thank you @Ollyws, yes, it looks like it's $250 based on this chat. I'll update the payment structure

[Ollyws]

We might want to double check that actually, the new ones seem to be $500. For example #25052 #24887

[Christinadobrzyn]

okay, let me ask the team for clarification! Thanks @Ollyws!

Asking here (for my own tracking) https://expensify.slack.com/archives/C01SKUP7QR0/p1698944041595109

[Christinadobrzyn]

hey @Ollyws they confirmed it's $250. It looks like the subject in those GHs that you mentioned was created automatically when the External label was added so I changed the amount to $250 for those jobs.

I paid you out based on this payment structure #24961 (comment)

Closing!