-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250][TS migration] Migrate 'QRCode' component to TypeScript #25000
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue. |
Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-30. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@VickyStash I noticed that the QRCode module is a directory which only contains one |
@roryabraham Sure, I'll do it tomorrow |
@AndrewGable can you assign me this as I helped with the Review checklist? |
@AndrewGable This was deployed to production, but the title for the payout wasn't updated. Can you help with that? |
|
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
@greg-schroeder - Can you please pay out $250? Thanks |
@AndrewGable @greg-schroeder I think I'll only need a payment summary here. I can raise my request on NewDot. |
@greg-schroeder @AndrewGable quick bump on the payout summary here. |
Sorry, I was out most of the week for the holiday. |
@mananjadhav please make a manual request in NewDot for $250 for the reviewer role |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: