Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] [HOLD for payment 2023-11-22] [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript #25059

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Closed

[$500] [HOLD for payment 2023-11-22] [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript #25059

melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
@NikkiWines @zanyrenney @shubham1206agra
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/SubscriptAvatar.js 12
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b55664b1bd2e72a
  • Upwork Job ID: 1729830662440402944
  • Last Price Increase: 2023-11-29
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Oct 27, 2023
@VickyStash VickyStash mentioned this issue Oct 27, 2023
Merged
59 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Nov 2, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript [HOLD for payment 2023-11-22] [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript Nov 15, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 15, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 22, 2023
@shubham1206agra
Copy link
Contributor

Can you assign me here?

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 27, 2023

@NikkiWines Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2023
@NikkiWines
Copy link
Contributor

Adding the appropriate labels so that someone on our team can issue payment for reviewing #30493

@NikkiWines NikkiWines added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 28, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@NikkiWines
Copy link
Contributor

@zanyrenney can we issue payment to @shubham1206agra for reviewing this TS migration PR please 🙇

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-22] [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript [$500] [HOLD for payment 2023-11-22] [TS migration] Migrate 'SubscriptAvatar.js' component to TypeScript Nov 29, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016b55664b1bd2e72a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 29, 2023

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

@zanyrenney
Copy link
Contributor

can you confirm the payment @NikkiWines $250 right?

@NikkiWines
Copy link
Contributor

Yep looks like it!

@zanyrenney
Copy link
Contributor

@shubham1206agra i have invited you to the job, please accept for payout.

@zanyrenney
Copy link
Contributor

payment summary:
$250 for @shubham1206agra for TS migration, thank you! closing!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikkiWines NikkiWines

@zanyrenney zanyrenney

@shubham1206agra shubham1206agra

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NikkiWines @VickyStash @zanyrenney @shubham1206agra