[HOLD for payment 2023-12-06] [TS migration] Migrate 'Button' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/Button/index.js	17
src/components/Button/validateSubmitShortcut/index.native.js	0
src/components/Button/validateSubmitShortcut/index.js	0

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fabioh8010]

Hi,
I'm Fábio from Callstack - an expert contributor group
I’d like to work on this issue

[parasharrajat]

As I am reviewing the first PR #30349. I am happy to review this migration as well.

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'Button' component to TypeScript #31102
• Fix/button component after ts migration #31906

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[srikarparsi]

Adding bug label for payment, @allroundexperts you reviewed this migration PR right?

[allroundexperts]

That's correct. Thanks @srikarparsi!

Can you jot down a payment summary please?

[srikarparsi]

Yeah, it should just be $250 for reviewing the PR right since an agency worked on the migration?

@allroundexperts - $250

[miljakljajic]

Thank you @srikarparsi - anyone else to pay here? It seems like there isn't, but just confirming.

[srikarparsi]

Hey! Yeah I think it's just $250 to @allroundexperts

[miljakljajic]

Payment summary:

$250 to Sibtain Ali @allroundexperts for their role as reviewer.

Thanks!

[JmillsExpensify]

$250 payment approved for @allroundexperts based on comment above.