Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-15] [$250] [TS migration] Migrate 'SettlementButton.js' component to TypeScript #25100

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/SettlementButton.js 18
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018a41880e78febd6d
  • Upwork Job ID: 1736777260313042944
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • ZhenjaHorbach | Contributor | 28077235
    • hoangzinh | Contributor | 28081224
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed Not a priority labels Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SettlementButton.js' component to TypeScript [$500] [TS migration] Migrate 'SettlementButton.js' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018a41880e78febd6d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Dec 18, 2023
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'SettlementButton.js' component to TypeScript [$250] [TS migration] Migrate 'SettlementButton.js' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Upwork job price has been updated to $250

@ishpaul777
Copy link
Contributor

i would love to take it

@KrAbhas
Copy link
Contributor

KrAbhas commented Dec 18, 2023

I would like to work on this

@ZhenjaHorbach
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'SettlementButton.js' component to TypeScript

What is the root cause of that problem?

Not problem (Technical ticket )

What changes do you think we should make in order to solve the problem?

We need to update this file using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)

NA

@rayane-djouah
Copy link
Contributor

I would like to work on this issue

@narefyev91
Copy link
Contributor

@ZhenjaHorbach is the first to #25100 (comment) with no other TS issue assigned.

🎀 👀 🎀 C+ reviewed.

@mountiny mountiny assigned hoangzinh and unassigned narefyev91 Jan 4, 2024
Copy link
Author

melvin-bot bot commented Jan 4, 2024

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny mountiny added the NewFeature Something to build that is a new item. label Jan 4, 2024
Copy link
Author

melvin-bot bot commented Jan 4, 2024

@mountiny
Copy link
Contributor

mountiny commented Jan 4, 2024

Yep thanks

Copy link
Author

melvin-bot bot commented Jan 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 29, 2024
Copy link
Author

melvin-bot bot commented Jan 29, 2024

This issue has not been updated in over 15 days. @AndrewGable, @twisterdotcom, @hoangzinh, @ZhenjaHorbach eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@twisterdotcom
Copy link
Contributor

The PR was merged two hours ago: #33866

I'll need to pay out @hoangzinh when it's deployed. Hopefully the title changes.

Copy link
Author

melvin-bot bot commented Feb 7, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 8, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'SettlementButton.js' component to TypeScript [HOLD for payment 2024-02-15] [$250] [TS migration] Migrate 'SettlementButton.js' component to TypeScript Feb 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Feb 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-15. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Feb 8, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@twisterdotcom
Copy link
Contributor

No need for regression tests, this is a TS migration.

@twisterdotcom
Copy link
Contributor

Payment summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

10 participants