Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-01-26] [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript #25108

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 30 comments
Closed

[HOLD for payment 2024-01-26] [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript #25108

melvin-bot bot opened this issue Aug 16, 2023 · 30 comments
Assignees
@puneetlath @mananjadhav @KrAbhas
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/MoneyReportHeader.js 20
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0152be230b0e427de5
  • Upwork Job ID: 1736777290641367040
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • KrAbhas | Contributor | 28064688
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed Not a priority labels Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript [$500] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0152be230b0e427de5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Dec 18, 2023
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript Dec 18, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 18, 2023

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.

@ishpaul777
Copy link
Contributor

i would love to take it.

@KrAbhas
Copy link
Contributor

KrAbhas commented Dec 18, 2023

I would like to work on this

@HezekielT
Copy link
Contributor

I would like to work on this.

@ZhenjaHorbach

This comment was marked as outdated.

Sign in to view
@mananjadhav
Copy link
Collaborator

mananjadhav commented Dec 18, 2023 •
edited
Loading

@KrAbhas is the first to comment with no other TS issue assigned.

🎀 👀 🎀 C+ reviewed.

@KrAbhas KrAbhas mentioned this issue Dec 25, 2023
Merged
49 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 25, 2023
@mananjadhav mananjadhav mentioned this issue Jan 14, 2024
Closed
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 18, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 18, 2024

This issue has not been updated in over 15 days. @mananjadhav, @flodnv, @KrAbhas eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@flodnv
Copy link
Contributor

flodnv commented Jan 18, 2024

Assuming we're done here. Please let me know if I'm wrong.

@flodnv flodnv closed this as completed Jan 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 18, 2024
@mananjadhav
Copy link
Collaborator

@flodnv Payout is pending for my C+ role in PR review..

@flodnv
Copy link
Contributor

flodnv commented Jan 18, 2024

Thanks, I wasn't sure, let's get that done

@flodnv flodnv reopened this Jan 18, 2024
@flodnv
Copy link
Contributor

flodnv commented Jan 18, 2024

If we didn't close the payment issue you would have gotten paid 😄 #34484 (comment)

@mananjadhav
Copy link
Collaborator

It was a duplicate issue. I think @KrAbhas is also an external contributor. So they would have to be paid out too.

@flodnv
Copy link
Contributor

flodnv commented Jan 18, 2024

@puneetlath since you were assigned to #34484, assigning you here for payment 😄

@flodnv flodnv added Daily KSv2 and removed Monthly KSv2 Reviewing Has a PR in review labels Jan 18, 2024
@flodnv flodnv removed their assignment Jan 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@puneetlath
Copy link
Contributor

Looks like we're still waiting on the regression period before paying this one.

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2024
@mananjadhav
Copy link
Collaborator

Yes but it looks like the automation failed. @puneetlath Can you update the issue title to reflect the held for payment and mention payout date?

@puneetlath puneetlath changed the title [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript [HOLD for payment 2024-01-26] [$250] [TS migration] Migrate 'MoneyReportHeader.js' component to TypeScript Jan 23, 2024
@puneetlath
Copy link
Contributor

Payment summary:

Thanks everyone!

@JmillsExpensify
Copy link

$250 approved for @mananjadhav based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@mananjadhav mananjadhav

@KrAbhas KrAbhas

Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
10 participants
@JmillsExpensify @puneetlath @mananjadhav @flodnv @mountiny @HezekielT @KrAbhas @yh-0218 @ZhenjaHorbach @ishpaul777