Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-01-17] [$500] [TS migration] Migrate 'QRShare' component to TypeScript #25124

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 24 comments
Closed

[HOLD for payment 2024-01-17] [$500] [TS migration] Migrate 'QRShare' component to TypeScript #25124

melvin-bot bot opened this issue Aug 16, 2023 · 24 comments
Assignees
@kevinksullivan @marcaaron @shubham1206agra
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023 •
edited
Loading

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/QRShare/propTypes.js 1
src/components/QRShare/index.js 13
src/components/QRShare/getQrCodeDownloadFileName.js 0
src/components/QRShare/QRShareWithDownload/index.native.js 6
src/components/QRShare/QRShareWithDownload/index.js 5
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ffacdfa464b6bc58
  • Upwork Job ID: 1744516015179104256
  • Last Price Increase: 2024-01-09
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack, expert contributor agency, and I would like to work on this issue!

@fabioh8010 fabioh8010 mentioned this issue Dec 7, 2023
Merged
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Dec 8, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 10, 2023

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@shubham1206agra
Copy link
Contributor

@marcaaron Can you assign me here as I am reviewing the above PR?

@marcaaron marcaaron added the NewFeature Something to build that is a new item. label Dec 12, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 12, 2023

Triggered auto assignment to @kevinksullivan (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@fabioh8010 fabioh8010 mentioned this issue Dec 20, 2023
Merged
50 tasks
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 4, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 4, 2024

This issue has not been updated in over 15 days. @kevinksullivan, @marcaaron, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 9, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 9, 2024
@kevinksullivan

This comment was marked as off-topic.

Sign in to view
@Tony-MK

This comment was marked as off-topic.

Sign in to view
@kevinksullivan kevinksullivan removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 9, 2024
@kevinksullivan
Copy link
Contributor

Apologies, help is not wanted and this is done.

@unidev727

This comment was marked as off-topic.

Sign in to view
@kevinksullivan
Copy link
Contributor

Also, TS migrations are always $250, right @marcaaron ?

@shubham1206agra
Copy link
Contributor

Yes. But this also has functional component migration too.

@fabioh8010
Copy link
Contributor

Hi @kevinksullivan @shubham1206agra This one was done by me from an expert agency, Callstack. So, no need for payment here.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 10, 2024
@melvin-bot melvin-bot bot changed the title [$500] [TS migration] Migrate 'QRShare' component to TypeScript [HOLD for payment 2024-01-17] [$500] [TS migration] Migrate 'QRShare' component to TypeScript Jan 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@kevinksullivan
Copy link
Contributor

Offer sent to @shubham1206agra for reviewing PR. Lmk when you accept

@shubham1206agra
Copy link
Contributor

Accepted

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 16, 2024
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 17, 2024 •
edited by kevinksullivan
Loading

Payment Summary

Upwork Job

BugZero Checklist (@kevinksullivan)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1744516015179104256/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@kevinksullivan
Copy link
Contributor

summary doesn't say anything, but it's $250. Paid.

@melvin-bot melvin-bot bot removed the Overdue label Jan 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinksullivan kevinksullivan

@marcaaron marcaaron

@shubham1206agra shubham1206agra

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabioh8010 @kevinksullivan @Tony-MK @marcaaron @shubham1206agra @unidev727