Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-22] [TS migration] Migrate 'GrowlNotification' component to TypeScript #25127

Open
melvin-bot bot opened this issue Aug 16, 2023 · 9 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Not a priority Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/GrowlNotification/index.js 12
src/components/GrowlNotification/GrowlNotificationContainer/index.native.js 6
src/components/GrowlNotification/GrowlNotificationContainer/index.js 5
src/components/GrowlNotification/GrowlNotificationContainer/growlNotificationContainerPropTypes.js 2
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@BartoszGrajdek
Copy link
Contributor

BartoszGrajdek commented Sep 12, 2023

For future reference to anyone working on this issue - make sure to move GrowlRef type into this component.

Here's the PR where GrowlRef type was added: #26933
Here's the discussion about handling ref types during TS migration: #26795 (comment)

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Feb 29, 2024
Copy link
Author

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hayata-suenaga hayata-suenaga reopened this Mar 5, 2024
@hayata-suenaga
Copy link
Contributor

The PR is open

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 12, 2024
Copy link
Author

melvin-bot bot commented Mar 12, 2024

@hayata-suenaga hayata-suenaga removed the NewFeature Something to build that is a new item. label Mar 12, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 15, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'GrowlNotification' component to TypeScript [HOLD for payment 2024-03-22] [TS migration] Migrate 'GrowlNotification' component to TypeScript Mar 15, 2024
Copy link
Author

melvin-bot bot commented Mar 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 15, 2024
Copy link
Author

melvin-bot bot commented Mar 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-22. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Not a priority Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants