-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-26] [TS migration] Migrate 'Onfido' component to TypeScript #25136
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue. |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Triggered auto assignment to @Christinadobrzyn ( |
I think we're waiting for the PR to merge into production still... #31378 |
I was C+ on the PR #31378 (comment) |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-26. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
after 3/26 - assuming no regressions, I think we can close this since @VickyStash is with Callstack and will be paid outside of this BZ. No regression test for TS migrations - unless you feel there should be for this one @VickyStash |
@Christinadobrzyn I was C+ on this as well. |
Ah thanks for confirming @parasharrajat! I can't remember, are you paid through NewDot? Payouts due: Contributor+: $250 @parasharrajat (In New Expensify) |
@Christinadobrzyn Yes, I am paid via NewDot. I will request it later. Please feel free to close this issue. Thanks. |
Sounds good! Closing since it's the 26th! |
Payment requested as per #25136 (comment) |
$250 approved for @parasharrajat |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: