Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [TS migration] Migrate 'Composer' component to TypeScript #25141

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/Composer/index.js 20
src/components/Composer/index.ios.js 7
src/components/Composer/index.android.js 7
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 30, 2023
@JKobrynski
Copy link
Contributor

The PR is ready for review!

@situchan
Copy link
Contributor

🎀 👀 🎀 to get engineer

Copy link
Author

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@situchan
Copy link
Contributor

@NikkiWines can you please help review #31912? Thanks

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority NewFeature Something to build that is a new item. labels Dec 15, 2023
Copy link
Author

melvin-bot bot commented Dec 15, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Composer' component to TypeScript [HOLD for payment 2023-12-28] [TS migration] Migrate 'Composer' component to TypeScript Dec 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @JKobrynski does not require payment (Contractor)
  • @situchan requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 27, 2023
@sonialiap
Copy link
Contributor

Not overdue, payment due tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2023
@sonialiap
Copy link
Contributor

sonialiap commented Dec 29, 2023

@situchan $250 - paid ✔️

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants