Deploy Checklist: New Expensify 2023-08-17

[OSBotify]

Release Version: 1.3.55-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Migrate Composer. web #23359
• The edited message does not dynamically update between the main chat and sub-thread #23706
• fix: revalidate upon input and refocus if error occurs #23995
• Display NVP-enabled Control policies in NewDot #24021
• [navigation-refactor] Fix browser history for complex navigation actions #24165
• Fix currency handling - always handle backend amounts as if they are in cents #24175
• fix: maintain native behavior when dragging links #24211
• Only show workspace chats as participants for distance #24236
• prevent blur on composer when click on mini context menu item #24252
• refactor: refactor money request form #24274
• fix: replace new report with preexisting #24320
• Migrate reportAction.originalMessage to transactions #24345
• fix: invoke useWindowDimensions #24353
• Update hover color for lounge access icon #24358
• fix: prevent unnecessary overlay from being added while opening RIGHT_DOCKED modals #24361
• Show reply in thread for IOU and Task. #24412
• Enable avatar preview for workspace & thread replies #24425
• fix: prevent browser form validation #24428
• formatting phone login #24441
• Ignore hasOutstandingIOU from child iouReport #24448
• Put link previews behind a beta for now #24475
• The country name is not displayed when you start entering "cote" or "cote d'Ivoire" without a diacritic, and instead you see "no results found" #24477
• Fix unexpected back navigation in Bank Connect flow #24480
• Hide reports with error from task share somewhere list #24506
• disable iOS keyboard avoiding view on screens without text input #24511
• Display status in chats #24526
• Fix report action is still detected as attachment even after we delete it #24539
• Fix Popover Emoji-reacted does not close for User B when User A deletes the message #24543
• fix workspace avatar shows U before reverting to actual avatar in IOU view #24551
• Fix reveal message button is copiable even though it's not selectable #24563
• fix: 24232 console log error when pressing ESC key #24567
• Do not show currency tooltip when we can't change it #24576
• Hide transaction detail and dismiss the edit modal when the request is deleted #24590
• Update context.xml #24592
• [No QA]Set an archive name for iOS #24594
• [NO QA] Add policyCategories collection key #24595
• [No QA]Specify output_name in fastlane to match up with previous names #24599
• [No QA]Add comma to new output_name key #24600
• [No QA] Ensure that no other updates are made to Onyx while missing Onyx updates are fetched and applied #24607
• Fix chat hidden from LHN when last message is attachment #24609
• Fix transaction amount sign and clean up unnecessary pay money request transaction  #24613
• Followup/23961 edit request autofocus and date #24634
• [NO QA] [Step 4] Add CORPORATE_CARD_LIST key #24641
• Offline mode: Crash after deleting Split Bill request - 25481 #25611

Internal QA:

• Allow any admin to see workspace settings #23626 - @mountiny

Deploy Blockers:

• [HOLD for payment 2023-08-28] [HOLD for payment 2023-08-24] LNH - The conversation will be removed from the LHN if the last message is an attachment #24593
• [HOLD for payment 2023-08-28] IOU - Cannot edit the amount field in a negative IOU request #24623
• [HOLD for payment 2023-08-28] Web - Request money - Unable to change currency for request money #25386
• [HOLD for payment 2023-08-28] Android - App crashes when tapping on Amount in IOU details page #25388
• Split bill - Split bill preview displays $0.00 when viewed as split bill participant #25389
• [HOLD for payment 2023-08-28] Web -Changed the request to ETB NaN" is shown when When saving with out chaging the amount #25390
• Request Money - Unexpected error requesting money message when send Request Money #25392
• [$1000] Web - Workspaces - Page goes to wrong page when clicking go to #admin rooms #25393
• [HOLD for payment 2023-08-28] [$1000] Chat - Email is pasted twice in the composer when copied from user profile #25409
• [$1000] Chat - Cursor does not remain the same place when Edit message #25413
• [HOLD for payment 2023-11-27] [$1000] Web - Chat - The display name goes down when deleting an attachment in main thread #25415
• Workspace - Newly created workspace does not appear in workspace list on second device #25423
• LHN - Page skeleton appears instead of LHN when going offline #25436
• [$1000] Details - blank shows instead of profile pic and workspace image #25447
• [HOLD for payment 2023-08-28] [$500] Request money - The app crashes when user deleted the request money #25451
• [ON HOLD - Waiting on #26190] Dev - User is unable to unlink secondary contact method #25472
• [HOLD for payment 2023-08-28] [$1000] Offline mode: Crash after deleting Split Bill request #25481
• Request money: 0.00 is shown for a seconds before updating its amount #25523
• Able to send multiple emoji by drag and drop #25525
• Adding emoji by text in edit shifts cursor #25526
• [HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$1000] CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything #25527
• Dev - user can type in composer while 'Delete request' modal is opened #25585
• [HOLD for payment 2023-10-16] [$1000] Dev: The "No result found" message showing after selecting a address from the drop-down menu #25595
• [$1000] Web - Girl with earings default avatar glitches when coming back from share code #25602
• Dev: Delay in removing 'New' marker After deleting newly sent message #25606
• Dev: Console error occurs when clicking "Request money" option #25608
• [HOLD for payment 2023-09-04] Console error on opening the report #25616

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.55-0 🚀

[youssef-lr]

Checked off #24021 after testing it myself.

[mountiny]

Checking #23626 off and confirming it works

[mvtglobally]

Regression is ongoing. About 30% left

PR #24175 is failing #25386 & #25394
PR #24236 pending validation on all platforms
#24252 is failing #23898. Repro in prod Checking off
#24274 is failing #25392
#24320 pending validation on all platforms
#24345 is failing #25388
#24361 pending validation on all platforms
#24448 is failing #25392
#24543 pending validation on all platforms
#24551 pending validation on all platforms
#24563 is failing
#24613 pending validation on all platforms

[marcaaron]

Checked off #25436 it's on prod already

[yuwenmemon]

@mvtglobally How close are we to completing QA?

[mvtglobally]

@yuwenmemon we are down to 10% TestRail left and 5 Pr/device validations.
At least an hour/two left to wrap up.

[mvtglobally]

@yuwenmemon down to 1% TR and 2 PRs

[mvtglobally]

Regression is down to just last 10 steps

PR #24175 is failing #25386 & #25394 & pending validation on Android.
PR #24236 pending validation on Android. Rest is pass
#24274 is failing #25392
#24345 is failing #25388
#24448 is failing #25392
#24563 is failing #24563 (comment)
#24613 is failing #24613 (comment)

[mvtglobally]

Regression is completed @yuwenmemon

Last unchecked issues

#24563 is failing #24563 (comment)
#24613 is failing #24613 (comment)

[Julesssss]

In the interest of getting the deploy out and not holding until Monday I'm looking at the remaining issues:

1. Fix reveal message button is copiable even though it's not selectable #24563 --> I'm unable to reproduce on staging v1.3.55-4. Additionally, this shouldn't block the deployment as it's quite a minor issue, not necessarily related to the PR changes
2. Fix transaction amount sign and clean up unnecessary pay money request transaction  #24613 --> a follow-up PR is in review but this should not block deploy

[Julesssss]

Finishing up the deployment to keep things moving as it's still very early on Friday.

• Github status: All Systems Operational ✅
• App Timing: Nominal
  
• Firebase Crashlytics:
  • New Android crash 😞 -- this one seems pretty prevalent, so I'm taking it to Slack
  • iOS - no new issues, one fixed

[Julesssss]

Of course, new blockers were just added... I believe some of these are related to changes on dev, and shouldn't block the deploy

[Julesssss]

@yuwenmemon I believe #25472 can be marked off. But we'll need to be careful to temporarily remove and then re-add the label so that it gets added to the next checklist...
#25472 (comment)

[Julesssss]

We reverted the MapBox PR in order to unblock AdHoc builds, CP in progress....

[mountiny]

Checking #25527 off, I dont think its a deploy blocker

[mountiny]

Checked off:

• [ON HOLD - Waiting on #26190] Dev - User is unable to unlink secondary contact method #25472
• Able to send multiple emoji by drag and drop #25525
• Adding emoji by text in edit shifts cursor #25526
• [HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$1000] CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything #25527
• Dev - user can type in composer while 'Delete request' modal is opened #25585

As they are either really minor edge cases which do not bear to be a deploy blockers or they actually occur in dev so we can deploy and they will be real blockers for the deploy tomorrow. never the less they should be treated with urgency

Only one deploy blocker left then #25481

[roryabraham]

Joining in as this week's NewDot deployer

[roryabraham]

Got a PR up to fix the last real blocker: #25481

Edit: Closed that PR in favor of #25611

[roryabraham]

Verified that #25481 is no longer reproducible on staging, checking it off...

[roryabraham]

#25595 is NAB, checking it off

[roryabraham]

#25602 is NAB, checking it off.

[roryabraham]

#25606 is NAB, checking it off.

[roryabraham]

#25608 not reproducible on staging, checking it off.

[roryabraham]

Same with #25616, checking it off.

[roryabraham]