[HOLD for payment 2024-01-22] [$250] [TS migration] Migrate 'SettingsSecuritySettings' page to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/settings/Security/SecuritySettingsPage.js	16

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c04e46df485aa8c
• Upwork Job ID: 1744724469137874944
• Last Price Increase: 2024-01-09
• Automatic offers:
• tienifr | Contributor | 28091820

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c04e46df485aa8c

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

This issue is a bit wonky, thanks everyone for offering to help, I assigned to @tienifr since they were the first to post. @allroundexperts do you need to add your 🎀 to assign the Engineer before @tienifr starts work? Bit out of the loop on the full process of TS migration issues

[shahinyan11]

@mallenexpensify the contributor assigned by you has already been assigned to another issue . Should not you choose another contributor ?

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Julesssss]

@mallenexpensify the contributor assigned by you has already been assigned to another issue . Should not you choose another contributor ?

In this case the PR is already raised, but I'll send Matt a link to our conversation from yesterday 👍

[mallenexpensify]

So.. this was my bad, I didn't see the post in Slack. We've discussed internally how to improve on this in the future.

@tienifr what was your intention with commenting for dibs on multiple issues when the post said

As before, please do not hoard issues, one contributor should only be assigned to one of these at a time, until merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate SettingsSecuritySettings to ts #34215

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

@Julesssss, @mallenexpensify, @allroundexperts, @tienifr Still overdue 6 days?! Let's take care of this!

[Julesssss]

@mallenexpensify can be paid out now 👍

[mallenexpensify]

Contributor: @tienifr paid $250 via Upwork
Contributor+: @allroundexperts owed $250 via NewDot

[JmillsExpensify]

$250 approved for @allroundexperts based on summary above.