Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'WorkspaceSettings' page to TypeScript #25191

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 14 comments
Closed

[TS migration] Migrate 'WorkspaceSettings' page to TypeScript #25191

melvin-bot bot opened this issue Aug 17, 2023 · 14 comments
Assignees
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/workspace/WorkspaceSettingsPage.js 26
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@fabioh8010
Copy link
Contributor

@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
Copy link
Author

melvin-bot bot commented Jan 18, 2024

📣 @ruben-rebelo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link
Author

melvin-bot bot commented Feb 12, 2024

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 22, 2024
Copy link
Author

melvin-bot bot commented Feb 22, 2024

Copy link
Author

melvin-bot bot commented Feb 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rushatgabhane
Copy link
Member

@isabelastisser could you please attach payment summary for review of #34897

@JmillsExpensify
Copy link

Awaiting payment summary.

@isabelastisser
Copy link
Contributor

isabelastisser commented Mar 18, 2024

Payment summary:

@ruben-rebelo $250 for PR review: #34897
@rushatgabhane $250 for PR Review: #34897

@JmillsExpensify
Copy link

I believe you're missing @rushatgabhane from that payment summary.

@isabelastisser
Copy link
Contributor

Sorry about that, @JmillsExpensify! The payment summary is now updated.

@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Not a priority Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants