Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [TS migration] Migrate 'react-native.js' mock to TypeScript #25256

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
mocks/react-native.js 3
mocks/pusher-js/react-native.js 1
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

Copy link
Author

melvin-bot bot commented Feb 6, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 6, 2024
@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review labels Feb 14, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 Overdue labels Feb 20, 2024
@JKobrynski
Copy link
Contributor

The PR is ready for review!

Copy link
Author

melvin-bot bot commented Feb 21, 2024

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'react-native.js' mock to TypeScript [HOLD for payment 2024-03-13] [TS migration] Migrate 'react-native.js' mock to TypeScript Mar 6, 2024
Copy link
Author

melvin-bot bot commented Mar 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2024
Copy link
Author

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@JKobrynski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@alitoshmatov
Copy link
Contributor

Can someone assign me to this issue to handle payment for review of the PR

@situchan
Copy link
Contributor

Payment is not needed for these kinds of PRs as per https://expensify.slack.com/archives/C02NK2DQWUX/p1707999906110839

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2024
Copy link
Author

melvin-bot bot commented Mar 13, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants