[HOLD for payment 2024-03-07] [TS migration] Migrate 'index.js' test to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
tests/e2e/server/index.js	4

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[fabioh8010]

Updated List

Files

Path	Dependencies
tests/e2e/server/index.js	5
tests/e2e/nativeCommands/index.js	3

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot]

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[kadiealexander]

@mountiny the status for this is done, should this be updated?

[mountiny]

Udpated

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] [TS migration] Migrate 'index.js' test to TypeScript #37126

If no regressions arise, payment will be issued on 2024-03-07. 🎊

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tgolen] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[tgolen]

No regression tests are necessary to be added for this one.

…

On Thu, Feb 29, 2024 at 4:28 PM melvin-bot[bot] ***@***.***> wrote: *BugZero Checklist:* The PR adding this new feature has been merged! The following checklist (instructions <https://stackoverflow.com/c/expensify/questions/14574>) will need to be completed before the issue can be closed: - ***@***.*** <https://github.com/tgolen>] Please propose regression test <https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md> steps to ensure the new feature will work correctly on production in further releases. - ***@***.*** <https://github.com/kadiealexander>] Link the GH issue for creating/updating the regression test once above steps have been agreed upon. — Reply to this email directly, view it on GitHub <#25303 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB4EVLXKIPS7KXNNC3LYV64R7AVCNFSM6AAAAAA3T5VEVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGE2DIMJSG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kadiealexander]

@tgolen it doesn't look like anyone listed as a reviewer is due payment as they all look to be from our expert agencies, but could you please buddy check my thinking there?

[tgolen]

I believe that's correct.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.