Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] [TS migration] Migrate 'Config' files to TypeScript #25331

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 23 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
config/proxyConfig.js 0
config/electronBuilder.config.js 1
config/webpack/webpack.dev.js 6
config/webpack/webpack.desktop.js 5
config/webpack/webpack.common.js 11
config/webpack/CustomVersionFilePlugin.js 3
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Feb 5, 2024
@melvin-bot melvin-bot bot reopened this Feb 9, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Mar 19, 2024
@JKobrynski
Copy link
Contributor

The PR is ready for review!

Copy link
Author

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Mar 29, 2024
Copy link
Author

melvin-bot bot commented Mar 29, 2024

@s77rt
Copy link
Contributor

s77rt commented Mar 29, 2024

@cead22 Please assign me here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Config' files to TypeScript [HOLD for payment 2024-04-15] [TS migration] Migrate 'Config' files to TypeScript Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)

Copy link
Author

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Apr 8, 2024

No regression test needed (not a NewFeature)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 14, 2024
Copy link
Author

melvin-bot bot commented Apr 15, 2024

Payment Summary

Upwork Job

  • ROLE: @s77rt paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kevinksullivan)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2024
Copy link
Author

melvin-bot bot commented Apr 18, 2024

@cead22, @s77rt, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cead22
Copy link
Contributor

cead22 commented Apr 18, 2024

On hold for payment, not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 18, 2024
Copy link
Author

melvin-bot bot commented Apr 22, 2024

@cead22, @s77rt, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cead22
Copy link
Contributor

cead22 commented Apr 23, 2024

On hold for payment, not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 23, 2024
Copy link
Author

melvin-bot bot commented Apr 26, 2024

@cead22, @s77rt, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link
Author

melvin-bot bot commented Apr 30, 2024

@cead22, @s77rt, @kevinksullivan Still overdue 6 days?! Let's take care of this!

@cead22
Copy link
Contributor

cead22 commented Apr 30, 2024

@kevinksullivan I think this is waiting on you

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@kevinksullivan
Copy link
Contributor

Looks like upwork automation failed here, I will create a job now.

@kevinksullivan
Copy link
Contributor

@s77rt offer sent, lmk when you accept!

@s77rt
Copy link
Contributor

s77rt commented May 1, 2024

@kevinksullivan Accepted! Thanks!

@kevinksullivan
Copy link
Contributor

all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants