-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Web - Settings - Unwanted behaviour when click on browser back button after clicking the report a bug #25412
Comments
Triggered auto assignment to @garrettmknight ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.When we click on report a bug and browser back button the transition is weird What is the root cause of that problem?We are not dismissing the about page from the stack when we go to the concierge chat here:
So when we click on the go back button it shows the about page briefly before going to the settings page What changes do you think we should make in order to solve the problem?We should use Navigation.dismissModal before navigating to concierge chat like this:
Result: 2023-08-17.10-53-01.mp4What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~01c4a8c2a8b4824bff |
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
Agreed that this looks like it should only pull up one menu and ideally the 'About' menu. |
@garrettmknight I have reported this issue, please update my username in the description so melvin can do automation, thanks |
Hey @ShogunFire can you update your proposal per @garrettmknight comment ? So the about page would be available after the back action |
Actually after reading the slack conversation this issue like others should have been tagged with [Tracking Browser back button] and it should be resolved by this PR #24165 I can't apply the patches so I still have the error but can someone try to reproduce after the patch ? |
Hello everyone
|
Hey, I am looking into this RN |
Could you check if it is still reproducible on the newest main @robertKozik and others? Seems like the issue is gone but maybe we are wrong. |
On it 👀 |
Can confirm - I cannot reproduce this issue on latest main (video attached) Screen.Recording.2023-08-23.at.11.10.32.mov |
Confirming it looks like it's been fixed. I'll still pay out @immadisetty-jaya-surya for reporting, but closing otherwise. Summary of Payments:
|
Reopening - couldn't find the bug reporter's Upwork profile. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@garrettmknight i m surya ...itz my upwork profile |
Thanks @immadisetty-jaya-surya - I can't seem to find you in the search on the job. Can you apply here so I can accept? https://www.upwork.com/jobs/~01c4a8c2a8b4824bff |
yeah @garrettmknight i applied which you have been send...!! |
Awesome, thanks! Offer sent. |
@garrettmknight Accepted the offer [:-) |
Nice, paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Either it should have only one transition to initial settings or about screen.
Actual Result:
it is giving the unpleasant transitions to initial settings or about screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.55-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
78862243032871902752023-08-04_00-32-06.MP4
Recording.5890.mp4
Expensify/Expensify Issue URL:
Issue reported by: @immadisetty-jaya-surya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691135024865169
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: