[HOLD #10414] [$1000] mWeb/Safari - Chat - Focus is lost and keyboard does not open when selecting ‘Edit comment’

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com in Mobile Safari on iPhone
2. Login with any account
3. Go to any chat with existing messages or send new message
4. Long tap on message
5. Select 'Edit comment' in context menu

Expected Result:

Message in 'Edit' mode > Keyboard is open and focus on the edited message

Actual Result:

Focus is lost and keyboard does not open when selecting ‘Edit comment’

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168903_mWeb-Edit-Focus-Lost.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d806d4cf680deb9
• Upwork Job ID: 1693666426126630912
• Last Price Increase: 2023-09-04

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sakluger]

Different issue, but slightly related to #24555 in that they are both unexpected behaviors when selecting Edit Comment in the mobile app.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d806d4cf680deb9

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[shubham1206agra]

Unable to repro in DEV
Is there any extra steps?

[swakeert]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After clicking Edit Comment, the text input box is not getting focussed, resulting in keyboard not opening automatically on mobile phones.

What is the root cause of that problem?

https://github.com/Expensify/App/blob/main/src/pages/home/report/ContextMenu/ContextMenuActions.js#L283

In the editAction function, we are not calling the focus method when closePopover is true. In all the other functions, ReportActionComposeFocusManager.focus(); is called in one way or the other, making sure the focus is correctly and manually set.

What changes do you think we should make in order to solve the problem?

We need to ensure the focus gets set on the correct text input. The ReportActionComposeFocusManager only handles focus on the default text input box for the main chat.

I would suggest creating a FocusManager that focuses on the newly created Edit Textbox and switches focus to it.

What alternative solutions did you explore? (Optional)

We can open the edit in its own page like 'reply in thread' functionality and set the focus to the default chat box using ReportActionComposeFocusManager, but that changes the UI and is not a bugfix.
PS: Seems like reply in thread is also not setting the focus correctly.

[jjcoffee]

@swakeert Your RCA is missing an explanation of why this would only apply to Safari mWeb (if that is indeed the case!). I'm also curious if you're able to reproduce the issue on latest main?

[sakluger]

Waiting on more proposals.

[jjcoffee]

@lanitochka17 are you still able to reproduce? We've reports that it's no longer reproducible.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[pradeepmdk]

this is a webkit issue https://bugs.webkit.org/show_bug.cgi?id=195884. both chrome and safari we will face this issue.

[jjcoffee]

@pradeepmdk Are you able to reproduce the issue on latest main? You're welcome to raise a proposal to fix the issue if so!

[pradeepmdk]

yes, @jjcoffee is still an issue there. i will try prepare the solution

[sakluger]

I was still able to reproduce this on staging and prod. @pradeepmdk looking forward to your proposal!

[melvin-bot]

@sakluger @jjcoffee this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sakluger]

@pradeepmdk how's it coming?

If we don't get any proposals soon, I'll ask our expert contributors to help out with this one.

[pradeepmdk]

@sakluger not yet. because they are allowing only user touch events based on their showing. We can't do anything here
We can check with expert contributors as well.

[sakluger]

Still on hold.

[sakluger]

Still on hold for #10414. I commented on that issue to see if we still planned to fix that one.

[sakluger]

Still on hold for #10414.

[sakluger]

Adding to vip-vsb since this is chat-related funcationality.

[sakluger]

Still on hold for #10414

[sakluger]

No updates on the hold issue.

[sakluger]

Still on hold.

[sakluger]

No update.

[sakluger]

Still no updates on the hold issue.

[sakluger]

Welp, the hold issue was closed. It seems like this just involves some inconsistent iOS behaviors that we've tried but failed to fix multiple times.

Since there really wasn't much work done on this issue, I'm just going to close it out. @jjcoffee feel free to raise in Slack you think we should reopen or if you think this requires some payment for work done.