Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-30] Payment issue for E/App PR#23060 #25518

Closed
melvin-bot bot opened this issue Aug 18, 2023 · 12 comments
Closed

[HOLD for payment 2023-08-30] Payment issue for E/App PR#23060 #25518

melvin-bot bot opened this issue Aug 18, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Issue created to compensate the Contributor+ member for their work on #23060
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @aimane-chnaif.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f029092225d9427e
  • Upwork Job ID: 1692680483055894528
  • Last Price Increase: 2023-08-18
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 18, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 18, 2023
@melvin-bot melvin-bot bot mentioned this issue Aug 18, 2023
56 tasks
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 18, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f029092225d9427e

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 18, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 18, 2023

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@sakluger
Copy link
Contributor

I sent an offer on the Upwork job. I'll pay out once the linked PR is deployed and settles for 7 days.

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@sakluger
Copy link
Contributor

Still waiting to be deployed to prod.

@sakluger
Copy link
Contributor

Deployed to prod yesterday (Aug 23)! Payment is due 8/30.

@sakluger sakluger changed the title Payment issue for E/App PR#23060 [HOLD for payment 2023-08-30] Payment issue for E/App PR#23060 Aug 24, 2023
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Aug 24, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 28, 2023

@sakluger, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@aimane-chnaif
Copy link
Contributor

I think we can close this as payment will be handled in original GH - #19496.
cc: @joekaufmanexpensify

@joekaufmanexpensify
Copy link
Contributor

Sounds good to me! @sakluger if it's cool with you, I'll close this one out, and pay @aimane-chnaif for this issue in the original issue shared above (using the upwork contract you hired them on in this issue).

@joekaufmanexpensify
Copy link
Contributor

Went ahead and issued this payment, as I was bug zero on the bug issue related to this PR. Not sure why this extra payment issue got opened.

The bounty on the issue related to this PR was $2k, so sent a $2,000 payment to @aimane-chnaif here, and ended the contract.

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@joekaufmanexpensify
Copy link
Contributor

Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants