[HOLD for payment 2023-09-21] [$1000] Web - Connect bank account- No sign is shown to indicating the account number and routing number can't be changed on Connect bank account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces
2. Select a workspace and access "Connect Bank Account."
3. Proceed to Step 3 out of 5.
4. Return to the Connect bank account(Step 1).
5. Notice that the account number and routing number can't be changed and no sign is shown indicating they can't be changed

Expected Result:

A sign is shown indicating they can't be changed

Actual Result:

No sign is shown indicating they can't be changed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-7

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T104.No.Sign.Is.Shown-1.mp4

20230821_194816.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691728690907359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0584ef975154c77
• Upwork Job ID: 1694056060363059201
• Last Price Increase: 2023-08-22
• Automatic offers:
• himanshuragi456 | Contributor | 26326916
• daveSeife | Reporter | 26326918

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[himanshuragi456]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Connect bank account - No sign is shown to indicate that the account number and routing number fields are non-editable

What is the root cause of that problem?

Although disabled prop is being passed properly in TextInput, and value is reaching properly to RNTextInput
But special cursor type is not added.

What changes do you think we should make in order to solve the problem?

make cursor not allowed

we can add in TextInput when input is in disabled state.

inputStyle={[styles.cursorDisabled]}

I believe this should be implemented throughout the app for disabled RNTextInputs, in that case this style should be added in RNTextInput of BaseTextInput.js

What alternative solutions did you explore? (Optional)

N/A

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Connect bank account- No sign is shown to indicating the account number and routing number can't be changed on Connect bank account

What is the root cause of that problem?

disabled prop is passed to TextInput in routing number account number here:

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 106 in 12bd6a7

disabled={shouldDisableInputs}

What changes do you think we should make in order to solve the problem?

We should update TextInput to have cursor: not-allowed when disabled prop is true.

What alternative solutions did you explore? (Optional)

[alitoshmatov]

Not to confuse anyone by editing my proposal, I would like to make addition and show exactly where I would have done the change:
Add this props.disabled?styles.cursorDisabled:{}, to here:

App/src/components/TextInput/BaseTextInput.js

Line 320 in 86e14db

style={[

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0584ef975154c77

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Connect bank account- No sign is shown to indicating the account number and routing number can't be changed on Connect bank account

What is the root cause of that problem?

We don't add the cursor style for text input and checkbox. I think the user isn't allowed to click the checkbox

What changes do you think we should make in order to solve the problem?

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 97 in 79ea923

<TextInput

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 110 in 79ea923

<TextInput

In 2 inputs here, we should add this style

inputStyle={[shouldDisableInputs && styles.cursorDisabled]}

We also add this style to checkbox here

App/src/pages/ReimbursementAccount/BankAccountManualStep.js

Line 122 in 79ea923

<CheckboxWithLabel

disabled={shouldDisableInputs}

And in CheckboxWithLabel, we will create new props called disabled and pass this prop to Checkbox Component

We also consider adding the grey background with decreasing opacity to text input and the checkbox like we did in other places

What alternative solutions did you explore? (Optional)

[himanshuragi456]

@Santhosh-Sellavel gently bump here

[Santhosh-Sellavel]

will look this today

[Santhosh-Sellavel]

@himanshuragi456 proposal is straight forward one, LGTM!

C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

@hayata-suenaga

I believe this should be implemented throughout the app for disabled RNTextInputs, in that case this style should be added in RNTextInput of BaseTextInput.js

This is the way to go, Let us know your thoughts on the proposal!

[DylanDylann]

@Santhosh-Sellavel I think we also should disable the checkbox for consistency as mentioned in my proposal. What do you think about this point?

[himanshuragi456]

@DylanDylann This is just a minor adjustment and can be handled/discussed in the PR, the overall approach still remains the same.

[DylanDylann]

@shawnborton Could you help to confirm that should we disable the checkbox for consistency in this issue? I see it will make more sense

[DylanDylann]

@DylanDylann This is just a minor adjustment

@himanshuragi456 Not minor (you don't mention it in your proposal). This issue is pretty straightforward and my proposal brings more value with other optional improvements as well for consistency.

[himanshuragi456]

@DylanDylann you've just pointed out an adjustment, the crux of the solution still remains the same.
If design teams suggests that change, I can just add that part too, main change will still be just adding the disabled cursor.

[shawnborton]

Do we know why they can't be changed?

But yeah, if they can't be changed, perhaps we can use more of a read-only version which would basically look like this existing pattern where we just label + value and no underline or right caret:

[himanshuragi456]

@hayata-suenaga Sure! Will raise the PR soon.

[hayata-suenaga]

@puneetlath

There was a discussion of payment in this Slack thread and in this comment in the PR.

I think we should't apply the penalty here as requirements changed several times, which caused a delay.

cc: @himanshuragi456

[puneetlath]

Makes sense 👍🏾

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @himanshuragi456 got assigned: 2023-08-25 15:30:56 Z
• when the PR got merged: 2023-09-13 05:07:10 UTC
• days elapsed: 12

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: change field style colors when input is not editable #25991

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)
• @himanshuragi456 requires payment offer (Contributor)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath / @hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel / @himanshuragi456] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel / @himanshuragi456] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@Santhosh-Sellavel friendly reminder on the checklist so that we can pay later this week. Thanks!

[Santhosh-Sellavel]

I think we can skip the checklist here as this end up as UI Polish not worth adding regression tests as well, Let me know your thoughts.

cc: @puneetlath @hayata-suenaga

[puneetlath]

Yep, I think that's fine for this one.

[puneetlath]

Payment summary:

@Santhosh-Sellavel - C+ - $1000 (to be paid via NewDot)
@himanshuragi456 - C - $1000 (paid via Upwork)
@daveSeife - B - $250 (paid via Upwork)

@Santhosh-Sellavel let me know when you've raised the request in NewDot and I'll close this out.

Thanks everyone!

[puneetlath]

@Santhosh-Sellavel friendly reminder on creating the NewDot request.

[Santhosh-Sellavel]

Requested on new dot

[puneetlath]

Great, closing!

[JmillsExpensify]

$1,000 payment approved for @Santhosh-Sellavel based on BZ summary.