[$2000] Web - Assign task - Undefined appears if task title is 0

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. click + button and select assign task option
3. enter 0 as title and click on Next button
4. click on confirm task button
5. check the task tile on shared user

Expected Result:

should show 0 as task title

Actual Result:

undefined appears instead of 0

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-7

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-11.At.4.52.28.Pm.mp4

20230821_201635.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691753089054979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3e0cc6a5e5cea69
• Upwork Job ID: 1694801608943554560
• Last Price Increase: 2023-09-06

Issue Owner

Current Issue Owner: @maddylewis

Issue Owner

Current Issue Owner: @neil-marcellini

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[himanshuragi456]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Undefined appears if the task title is 0

What is the root cause of that problem?

improper check state in the title field, 0 is considered as false

What changes do you think we should make in order to solve the problem?

N/A

[DylanDylann]

I think it is a BE bug, when the task title is 0, BE don't return childReportName field

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e3e0cc6a5e5cea69

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[melvin-bot]

@mollfpr, @maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[maddylewis]

adding external label

[jjcoffee]

@maddylewis Actually scratch that, I can't reproduce on prod v1.3.56-24 or staging v1.3.57-5, so I think this must have been fixed!

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[neil-marcellini]

I added this to my list of weekly issues as the 3rd most important one.

[maddylewis]

got it! @neil-marcellini - lmk if i can do anything to help move this along. or, is this waiting on an internal eng review at this point?

[neil-marcellini]

Ok I felt bad about letting this drag on longer. After 1 hour of debugging I found the 1 line fix on the backend 😅

[melvin-bot]

This issue has not been updated in over 15 days. @neil-marcellini, @jjcoffee, @maddylewis eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[maddylewis]

is this resolved? https://github.com/Expensify/Web-Expensify/pull/39198

i don't think there is any payment due for this one since it was worked on by an internal/contractor engineers, but lmk - ty!

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[maddylewis]

just confirming if there's any thing left to do on this one before closing! #25588 (comment)

[jjcoffee]

I think @gadhiyamanan may be due payment for the bug report? Otherwise nothing else!

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@neil-marcellini, @jjcoffee, @maddylewis 12 days overdue. Walking. Toward. The. Light...

[maddylewis]

thanks @jjcoffee - i will get that done now!

[maddylewis]

the upwork job was no longer open so i created a new job - $250 reporting bonus sent to @gadhiyamanan. once the offer is accepted, i will close this out.

[gadhiyamanan]

@maddylewis offer accepted, thanks!

[maddylewis]

paid!