[HOLD for payment 2023-10-10] [$500] Stop storing queued Onyx updates to disk

[marcaaron]

Problem

In some cases, the payload of OpenApp is very large and since we save all Onyx responses to disk in queuedOnyxUpdates this leads to double-storing our largest resource. It will be deleted after, but doesn't seem like there is a clear reason why these updates should be persisted instead of just hanging around in memory.

Solution

Let's store the "queued updates" in memory instead.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01451356cead02359a
• Upwork Job ID: 1702119738769117184
• Last Price Increase: 2023-09-29

[marcaaron]

Just blocked on testing on all platforms. Will try to get this done today.

[melvin-bot]

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

Focusing on pagination research atm. I will try to run through test steps for this one today.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01451356cead02359a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[marcaaron]

Hey @alexpensify this is something I am fixing and enlisting the C+ to help with on reviews. There was no bug report or anything as it's more of an improvement, so I checked off everything on the BZ checklist.

[alexpensify]

@marcaaron - when is the payment date for this one?

[alexpensify]

It looks like the PR is moving along but there is a lint error to address.

[alexpensify]

@marcaaron can you review the lint error flag? Thanks!

[marcaaron]

Yep sorry this one slipped through the cracks - thanks for the bump @alexpensify

[marcaaron]

Merged and waiting for deploy

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[alexpensify]

@situchan - it looks like automation might not kick in, so please apply here:

https://www.upwork.com/jobs/~01451356cead02359a

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Save queued updates to memory only #25614

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@situchan looks like the previous Upwork link was not working, so can you apply to this one --- https://www.upwork.com/jobs/~01a80b6b1d1c2a3260

Thanks!

[situchan]

Applied thanks

[alexpensify]

Here is the payment summary:

• External issue reporter N/A
• Contributor that fixed the issue N/A
• Contributor+ that helped on the issue and/or PR @situchan $500

Upwork Job: https://www.upwork.com/jobs/~01a80b6b1d1c2a3260

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: Confirmed here that there is no need to complete the BZ -- #25612 (comment)

[alexpensify]

@situchan - I've extended the contract in Upwork, please accept and I can complete he payment process. Thanks!

[alexpensify]

The payment has been sent out. All set here, so closing for now.