[HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626

mountiny · 2023-08-21T22:24:49Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Break down in numbered steps

Click on FAB
Request Money
On the amount page, click the currency symbol to change the currency
Select some other currency

Expected Result:

Describe what you think should've happened

You are back on the amount page with selected currency

Actual Result:

Describe what actually happened

The modal has closed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01732c4f8d4d117765
Upwork Job ID: 1694010840997621760
Last Price Increase: 2023-08-31
Automatic offers:

0xmiroslav | Reviewer | 26452949
shubham1206agra | Contributor | 26452951

melvin-bot · 2023-08-21T22:24:54Z

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-21T22:24:56Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-08-21T22:26:33Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-08-21T22:26:37Z

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

OSBotify · 2023-08-21T22:28:10Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

c3024 · 2023-08-21T22:41:57Z

Unable to reproduce on latest dev. Am I missing some repro steps?

Screen.Recording.2023-08-22.at.4.10.45.AM.mov

mountiny · 2023-08-21T22:47:02Z

forgot to include this:

Screen.Recording.2023-08-21.at.23.46.17.mp4

conorpendergrast · 2023-08-22T09:03:48Z

I reproduced on Staging

conorpendergrast · 2023-08-22T09:06:45Z

I agree that this is a deploy blocker. @mountiny @roryabraham any ideas for which PR caused this?

cubuspl42 · 2023-08-22T10:14:08Z

@mountiny @conorpendergrast I reproduced this. I can work on this if you're still looking for someone.

mountiny · 2023-08-22T10:28:38Z

@cubuspl42 We are actively looking into this one, if you have a valid proposal identifying the offending PR (this is a deploy blocker so there must have been a recent change in staging which introduced it), I could let you work on it for $500

cubuspl42 · 2023-08-22T10:28:54Z

So far it looks to me like it was always broken with the ("Manual" / "Scan" / "Distance") header, which is under beta. So that would mean it's been broken for weeks. So I guess it's not a release blocker?

(But I haven't confirmed this for 100%)

cubuspl42 · 2023-08-22T10:32:51Z

@mountiny Could you test this with this manual patch?

function canUseScanReceipts(betas) {
    return false; // <--
    return _.contains(betas, CONST.BETAS.SCAN_RECEIPTS) || canUseAllBetas(betas);
}

(Maybe same for canUseDistanceRequests)

Pluto0104 · 2023-08-22T10:34:06Z

@cubuspl42, Of course, it can be only reproduced with "Manual" / "Scan" / "Distance" header.

cubuspl42 · 2023-08-22T10:34:56Z

@Pluto0104 But are bugs reproducible only with beta features considered deploy blockers?

Pluto0104 · 2023-08-22T10:39:25Z

@cubuspl42, Since I'm new to contributing to this project, I may not have a thorough understanding of the beta features yet. However, based on my current knowledge, I don't believe the bug is severe, frequent, or affecting a significant number of users who rely on the beta feature. Therefore, I don't consider it to be a deploy blocker.

cubuspl42 · 2023-08-22T10:41:54Z

@mountiny Anyway, let me know if we degrade this to a non-blocker and if the work offer you proposed stands.

mountiny · 2023-08-22T10:44:58Z

So far it looks to me like it was always broken with the ("Manual" / "Scan" / "Distance") header, which is under beta. So that would mean it's been broken for weeks. So I guess it's not a release blocker?

The beta worked fine for us for weeks, this is indeed recent

mountiny · 2023-08-22T10:46:09Z

In general, you are right that beta features might not be considered as deploy blockers. At the moment tho the Scan and Distance are our highest priority so we definitely want to fix this asap. It is also making testing of new features locally where the betas are enabled harder

melvin-bot · 2023-09-11T11:57:18Z

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

conorpendergrast · 2023-09-11T11:58:07Z

@abekkala I'm on parental leave; re-assigning! This is set for payment today and a review to see if @parasharrajat should be considered as reporter too

abekkala · 2023-09-11T14:10:18Z

@mountiny since this was reported by @parasharrajat on Aug 18 https://expensify.slack.com/archives/C049HHMV9SM/p1692371427006799
Can they be noted as the reporter for reporting bonus?

abekkala · 2023-09-11T14:24:21Z

PAYMENT DETAILS:

Reporter: Vit
@shubham1206agra offer (Contributor who fixed)
@0xmiroslav offer (PR Reviewer)

@mountiny I also reviewed the PR - can you confirm the delay was due to QA an bonus is warranted?

mountiny · 2023-09-11T14:55:32Z

@parasharrajat is a reported I believe

This was linked to multiple issues and we did not get this merged that fast, not saying by contirbutors mistake, but I believe the urgency bonus should be really applied when its merged fast as a collective effort.

I do not see @0xmiroslav as a reviewer here, @0xmiroslav can you confirm your work on this issue please? thanks!

0xmiros · 2023-09-11T16:17:39Z

@0xmiroslav can you confirm your work on this issue please? thanks!

Here's context:

I reviewed initial proposals and helped testing patch (merged PR) and confirmed that it fixed both issues.
Discussion also happened in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1693564076055399?thread_ts=1693510185.535349&cid=C01GTK53T8Q
Since PR was linked to original issue first time, original C+ (Olly) was assigned as reviewer but he was not available soon so @mountiny filled checklist himself.

mountiny · 2023-09-11T16:59:13Z

Thanks

abekkala · 2023-09-11T17:56:26Z

Payments for today:

Reporter: @parasharrajat [$250 as this was reported prior to Aug 30] Gets Paid via EChat
@shubham1206agra offer (Contributor who fixed) [$2000 - no bonus]
@0xmiroslav offer (PR Reviewer) [$2000 - no bonus]

@0xmiroslav can you complete the checklist above so I can complete payments?

0xmiros · 2023-09-11T17:57:29Z

@0xmiroslav can you complete the checklist above

#25626 (comment)

abekkala · 2023-09-11T19:07:39Z

@shubham1206agra - paid and contract ended! 🎉 Thank You!

@0xmiroslav can you accept the offer, in Upwork, so I can submit payment: https://www.upwork.com/nx/wm/offer/26452949

@parasharrajat - payment is made via EChat

0xmiros · 2023-09-11T19:09:59Z

@abekkala sorry please hold my payment yet. I will let you know when ready.
Internal discussion

parasharrajat · 2023-09-11T19:17:27Z

@abekkala Payment requested as per #25626 (comment)

abekkala · 2023-09-11T19:23:52Z

@parasharrajat ah yes, I see now that you get paid via Expensify Chat

abekkala · 2023-09-14T19:31:14Z

not overdue - waiting on further guidance on payment

JmillsExpensify · 2023-09-21T09:34:16Z

$250 payment for @parasharrajat approved based on BZ summary.

abekkala · 2023-09-29T01:48:53Z

STATUS:
Waiting on @0xmiroslav.
https://expensify.slack.com/archives/C01SKUP7QR0/p1695166357917099?thread_ts=1694206723.155449&cid=C01SKUP7QR0

Please ping me here when you're able to accept payments in Upwork.

abekkala · 2023-10-31T15:25:35Z

@0xmiroslav are you ready to accept payments via Upwork yet?

0xmiros · 2023-10-31T15:31:56Z

Let's close this for now. I am tracking locally

mountiny added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 21, 2023

melvin-bot bot assigned conorpendergrast Aug 21, 2023

mountiny added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment labels Aug 21, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 21, 2023

OSBotify mentioned this issue Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot bot assigned roryabraham Aug 21, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 11, 2023

This comment was marked as duplicate.

Sign in to view

melvin-bot bot added the Overdue label Sep 14, 2023

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Sep 14, 2023

abekkala added Monthly KSv2 and removed Weekly KSv2 labels Sep 29, 2023

abekkala changed the title ~~[HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$2000] Request Money modal closed when selecting currency for new request or edit~~ [HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit Sep 29, 2023

abekkala closed this as completed Oct 31, 2023

[HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626

[HOLD for @0xmiroslav payment] [$2000] Request Money modal closed when selecting currency for new request or edit #25626

Comments

mountiny commented Aug 21, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 21, 2023

melvin-bot bot commented Aug 21, 2023 • edited by conorpendergrast Loading

Bug0 Triage Checklist (Main S/O)

OSBotify commented Aug 21, 2023

melvin-bot bot commented Aug 21, 2023

OSBotify commented Aug 21, 2023

c3024 commented Aug 21, 2023

mountiny commented Aug 21, 2023

conorpendergrast commented Aug 22, 2023

conorpendergrast commented Aug 22, 2023

cubuspl42 commented Aug 22, 2023

mountiny commented Aug 22, 2023

cubuspl42 commented Aug 22, 2023 • edited Loading

cubuspl42 commented Aug 22, 2023 • edited Loading

Pluto0104 commented Aug 22, 2023

cubuspl42 commented Aug 22, 2023

Pluto0104 commented Aug 22, 2023

cubuspl42 commented Aug 22, 2023

mountiny commented Aug 22, 2023

mountiny commented Aug 22, 2023

melvin-bot bot commented Sep 11, 2023

This comment was marked as duplicate.

conorpendergrast commented Sep 11, 2023

abekkala commented Sep 11, 2023

abekkala commented Sep 11, 2023

mountiny commented Sep 11, 2023

0xmiros commented Sep 11, 2023

mountiny commented Sep 11, 2023

abekkala commented Sep 11, 2023 • edited Loading

Payments for today:

0xmiros commented Sep 11, 2023

abekkala commented Sep 11, 2023 • edited Loading

0xmiros commented Sep 11, 2023

parasharrajat commented Sep 11, 2023

abekkala commented Sep 11, 2023

abekkala commented Sep 14, 2023

JmillsExpensify commented Sep 21, 2023

abekkala commented Sep 29, 2023

abekkala commented Oct 31, 2023

0xmiros commented Oct 31, 2023

mountiny commented Aug 21, 2023 •

edited

Loading

melvin-bot bot commented Aug 21, 2023 •

edited by conorpendergrast

Loading

cubuspl42 commented Aug 22, 2023 •

edited

Loading

cubuspl42 commented Aug 22, 2023 •

edited

Loading

abekkala commented Sep 11, 2023 •

edited

Loading

abekkala commented Sep 11, 2023 •

edited

Loading