[HOLD for payment 2023-09-29] [$1000] Web - No Transition animation for task assignee/share-somewhere modal

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click FAB, Click Assign task
2. Enter title, click continue.
3. Click on Assignee Option, see there is no animation.
4. Click on Share somewhere, see there is no animation.

Expected Result:

There should be animation for the 2 screen/modals

Actual Result:

No Animation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-21

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Kapture.2023-08-13.at.02.21.01.mp4

Recording.1307.mp4

Expensify/Expensify Issue URL:

Issue reported by: @b4s36t4

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691873619811189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d36654a811c7c838
• Upwork Job ID: 1696763981295181824
• Last Price Increase: 2023-08-30
• Automatic offers:
• b4s36t4 | Contributor | 26515110
• b4s36t4 | Reporter | 26515112

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Proposal from @b4s36t4

Please re-state the problem that we are trying to solve in this issue.

No Transition animation for task assignee/share-somewhere modal

What is the root cause of that problem?

RCA for this issue is with the inputs we have inside these modals which are getting instant focus causing the break in animation.

What changes do you think we should make in order to solve the problem?

We can solve this issue with two methods

1. Using shouldDelayFocus prop should do that work.
2. Using the ref to access textInput ref inside the BaseOptionsSelector component and focus the input after animation done inside the onEntryTransitionEnd prop for ScreenWrapper component.
   Reference: fix: workspace members invite page transition #22217 Kind of same issue.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Fair enough. I'm triaging this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d36654a811c7c838

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[b4s36t4]

Edits

Changes needed

ref={(el) => (textRef.current = el)}
``` to be passed to `OptionsSelector` and using the ref to focus when `onEntryTransitionEnd` for `ScreenWrapper`.

Kapture.2023-08-30.at.11.42.51.mp4

[melvin-bot]

@JmillsExpensify, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[rushatgabhane]

I like @b4s36t4's proposal #25802 (comment) to fix this issue by focusing the input after transition ends. i.e. using onTransitionEnd

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[b4s36t4]

Due to some issues I had to close first raised PR, created a new PR here #27220

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @b4s36t4 got assigned: 2023-09-05 20:59:37 Z
• when the PR got merged: 2023-09-19 08:29:14 UTC
• days elapsed: 9

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix transition for task assignee modals #27220

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @b4s36t4 requires payment offer (Contributor)
• @b4s36t4 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR:
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @b4s36t4] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @b4s36t4] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

WIP ⚠️

1. The PR that introduced the bug has been identified. Link to the PR:

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

4. Determine if we should create a regression test for this bug.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/8090629748489428

[melvin-bot]

@JmillsExpensify, @rushatgabhane, @b4s36t4 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @rushatgabhane, @b4s36t4 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify, @rushatgabhane, @b4s36t4 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Payment summary:

• Issue reporter: @b4s36t4 $250
• Contributor: @b4s36t4 $1,000
• Contributor+: @rushatgabhane $1,000

[JmillsExpensify]

$1,000 payment approved for @rushatgabhane based on summary above.

[JmillsExpensify]

@b4s36t4 Upwork offer sent!

[b4s36t4]

@JmillsExpensify accepted the offer.

[JmillsExpensify]

All paid out. Thank you!