-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Request money - App crashes when editing Amount twice #25841
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @amyevans ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Android - Request money - App crashes when editing Amount twice What is the root cause of that problem?
uri doest not support local image this pr is enabled this feature https://github.com/Expensify/App/pull/24235/files when first time editMoneyRequest called we are getting with receipt so that on second time we are setting as open in optimastic data so at the time has receipt is there and open the <ReportActionItemImage /> and we are trying to show the image ..so at the time we are passing wrong source param and app is brokenApp/src/libs/TransactionUtils.js Lines 123 to 125 in 329cac3
What changes do you think we should make in order to solve the problem?here in ReportActionItemImage uri will doesn't support local assets file path.
so we need 'ReportActionItemImage' one more props if we are trying to load assets image means
and this function should return and if (shouldStopSmartscan && _.has(transaction, 'receipt') && !_.isEmpty(transaction.receipt) && !_.isEmpty(lodashGet(transaction, 'receipt.state')) && lodashGet(transaction, 'receipt.state') !== CONST.IOU.RECEIPT_STATE.OPEN) {
updatedTransaction.receipt.state = CONST.IOU.RECEIPT_STATE.OPEN;
} |
Hey guys I think this bug report might have the same root cause as the one I have reported. And my report came first here on slack. |
@pradeepmdk I don't think I'm following your proposal. The If it does have something to do with that PR, the PR has already deployed to production, so this wouldn't be a deploy blocker. @lanitochka17 could you try to reproduce the issue on production again and confirm for me if it crashes or not? |
@amyevans I agree is shown only when have 'receipt', but when
at the time ReportActionItemImage is showing. Line 974 in 329cac3
but when
local assets image when we import its has a reference number not a actual path |
@amyevans fyi this will be fixed with the next auth deploy happening real soon I think https://github.com/Expensify/Auth/pull/8562 So maybe we can just wait |
@mountiny still we have an issue with loading images from local assets
Local assets should be passed to without uri |
https://github.com/Expensify/Auth/pull/8562 has been deployed |
I think not reproducible now as the receipt state is not updated unnecessarily when the request type is not scan. |
Cool, @roryabraham mind confirming the issue is no longer reproducible? My Android build is hosed at the moment, trying to get that going again but in the meantime I can't test 😅 |
Confirmed, no longer reproducible. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #24630
Action Performed:
Expected Result:
App does not crash
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.57-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6175499_Screen_Recording_20230824_195139_One_UI_Home.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: