[HOLD for payment 2023-09-06] [$1000] No animation for Members and Invite Members page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on you avatar and open settings
2. Go to workspaces and open any workspace
3. Click on Members and Notice the RHP animation
4. Then Click on Invite and Notice the animation

Expected Result:

Opening Members and Invite members should be animated

Actual Result:

There is no animation for Members and Invite Members page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.24-08-23.09_25_07.webm

Recording.1503.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692860888835619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fd938c0400af0e16
• Upwork Job ID: 1694755918563115008
• Last Price Increase: 2023-08-24
• Automatic offers:
• DrLoopFall | Contributor | 26308867
• Ahmed-Abdella | Reporter | 26308869

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[CortneyOfstad]

@roryabraham Just about to jump into a client call, but should only be out about 30 minutes. If something pops up that needs my assistance, just ping me 👍

[situchan]

Related to #22622

[DrLoopFall]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No animation for Members and Invite Members page

What is the root cause of that problem?

The Members page and Invite Members page have TextInput with autofocus, which breaks the animation.

What changes do you think we should make in order to solve the problem?

Adding ShouldDelayFocus to SelectionList, would fix the animation.

What alternative solutions did you explore? (Optional)

Use onEntryTransitionEnd to focus the TextInput, after the animation is completed.

[roryabraham]

Not going to block deploy on this, but it's a valid bug we should fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fd938c0400af0e16

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[shubham1206agra]

@roryabraham If this is not a blocker then I think you should add this to the tracking #11795

[roryabraham]

Use onEntryTransitionEnd to focus the TextInput, after the animation is completed.

@DrLoopFall I actually think that this is a more robust solution so we should use that instead of the setTimeout approach. I'm inclined to accept @DrLoopFall's proposal and not put this on HOLD needlessly, but I'll check with @mountiny first.

[roryabraham]

@mountiny agrees, no need to put this on HOLD

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter — as clarified here and here, payment is not eligible.
• Contributor that fixed the issue — @DrLoopFall was paid $1000
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @DrLoopFall requires payment offer (Contributor)
• @Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR: [Tracker] Selection List Refactor #11795
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: I worked with @thiagobrez to work on a robust solution in this PR. We also chatted about it over a beer 🍻
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979
• [@DrLoopFall] Determine if we should create a regression test for this bug.
• [@DrLoopFall] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[roryabraham]

@Ahmed-Abdella yes, I think we should pay the reporting bonus here as well 👍

[sakluger]

@roryabraham - A single PR fixed multiple issues including this one, and a different GH issue (#25890) was reported first in expensify-bugs in Slack. Generally we only pay out for the first bug report, I'll let @CortneyOfstad make the final decision.

[Ahmed-Abdella]

But they are two different issues and this wouldn't be fixed without this report.

[CortneyOfstad]

Asking internally about this here.

[CortneyOfstad]

Bumped the thread again. Will update as soon as I can 👍

[Ahmed-Abdella]

Hey @CortneyOfstad , I would like to clarify one thing. How could this issue be resolved without this report? it will only be resolved after the report is made. If It was just the first issue that was reported, this issue would not be fixed. I believe that this report serves its purpose. Please do not misunderstand me, I am OK with whatever decision the team makes. I just want to comprehend the process.

[CortneyOfstad]

@Ahmed-Abdella the team determined that we only pay a reporting bonus once per PR. If the PR fixes multiple bugs, that means they all had the same root cause and we only pay the initial report that caused the PR to be created/deployed.

Because of that, the reporting bonus will not be applied here.

[CortneyOfstad]

Payment has been made to @DrLoopFall and contract completed in Upwork 👍

[CortneyOfstad]

@roryabraham update on the checklist above? ^^^

[roryabraham]

@CortneyOfstad done!

[DrLoopFall]

BugZero Checklist:

• [@DrLoopFall] Determine if we should create a regression test for this bug: No, since it's not an impactful bug, I don't think we need a regression test.
• [@DrLoopFall] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again: N/A

[CortneyOfstad]

Sounds good! Are we able to close this out?

[melvin-bot]

@CortneyOfstad, @roryabraham, @DrLoopFall Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Closing this out — feel free to reopen if needed

CC @DrLoopFall @roryabraham