[HOLD for payment 2023-09-20] [$1000] DEV: Share code avatar differs from profile avatar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to the Settings > Share Code.
2. Note the inconsistency in avatars.

Expected Result:

Both the profile and Share Code avatars should match

Actual Result:

The avatar in the Share Code differs from the one displayed in the profile

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-25-at-124520-am_lxnFUnql.mp4

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692906813354439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a91b4da2caec2a9a
• Upwork Job ID: 1695128865636945920
• Last Price Increase: 2023-09-01
• Automatic offers:
• StevenKKC | Contributor | 26516719
• niravkakadiya25 | Reporter | 26516722

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

DEV: Share code avatar differs from profile avatar

What is the root cause of that problem?

Root cause for this problem here is here at this line.

App/src/libs/UserUtils.js

Line 151 in 74be5f6

return isDefaultAvatar(avatarURL) ? getDefaultAvatar(accountID) : avatarURL;

For ShareCodePage we're using getAvatarUrl and if it's a default URL we're fetching New Dot avatar. But for the function we're using in InitialSettingsPage getAvatar is not passing getDefaultAvatar 2nd parameter (new dot as boolean) which fetches avatar from old dot.

What changes do you think we should make in order to solve the problem?

We have to use newdot in both the places.

What alternative solutions did you explore? (Optional)

NA

[StevenKKC]

Proposal

Please state again the problem we are trying to solve in this issue.

Share code avatar differs from profile avatar.

What is the cause of this issue?

We uses UserUtils.getAvatar in profile page, and this function uses UserUtils.getDefaultAvatar.
And we uses UserUtils.getAvatarURL in share code page, and this function uses UserUtils.getDefaultAvatarURL.

In #25816, UserUtils.getDefaultAvatar updates the calculation of default avatar.

App/src/libs/UserUtils.js

Line 92 in b38181a

const accountIDHashBucket = (accountID % CONST.DEFAULT_AVATAR_COUNT) + 1;

But in UserUtils.getDefaultAvatarURL, we are using original hash calculation.

App/src/libs/UserUtils.js

Line 111 in b38181a

const accountIDHashBucket = hashText(String(accountID), isNewDot ? CONST.DEFAULT_AVATAR_COUNT : CONST.OLD_DEFAULT_AVATAR_COUNT) + 1;

What changes do you think we should make to solve the problem?

We should use same calculation in UserUtils.getDefaultAvatarURL.

const accountIDHashBucket = (Number(accountID) % (isNewDot ? CONST.DEFAULT_AVATAR_COUNT : CONST.OLD_DEFAULT_AVATAR_COUNT)) + 1;

What alternative solutions have you investigated? (Optional)

None.

[StevenKKC]

This only reproducible on DEV, I think not a deploy blocker.

[luacmartins]

This is really minor and not a blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a91b4da2caec2a9a

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[luacmartins]

@rushatgabhane let me know when you get a chance to look at the current proposals

[StevenKKC]

@mallenexpensify I am afraid to let you know that My Upwork account is suspended so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account.

[mallenexpensify]

@StevenKKC we're currently researching how best to address situations like this. While we do, can you please try to get your Upwork account active again, since that will be the easiest and best way to pay

[StevenKKC]

Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled.

[JmillsExpensify]

$1,500 payment approved for @rushatgabhane based on BZ summary.

[luacmartins]

Are we all done here?

[StevenKKC]

@luacmartins, @mallenexpensify What should I do now? May I receive the payment via my friend's account?

[mallenexpensify]

@StevenKKC we're still discussing possible options. as a reminder, per our CONTRIBUTING.md and Upwork's ToS, they both required active and verified Upwork accounts in order to get paid.

• Our CONTRIBUTING.md which states "Please make sure your Upwork profile is fully verified before applying, otherwise you run the risk of not being paid."
• Upwork's TOS which states "If you break any of these rules, we can suspend your account and stop you from using Upwork"

[StevenKKC]

@mallenexpensify You are right. And I have already get paid 25K+ with my Upwork account. But unfortunately my Upwork account is suspended permanently so I am trying to get paid via My friend's Upwork account that fully verified.

[mallenexpensify]

I'm actively discussing options with Upwork @StevenKKC , hoping to have an update for you next week, my contact is out this week.

[luacmartins]

Still trying to sort payment issues.

[mallenexpensify]

Underpaid @niravkakadiya25 so I just bonused $200 and updated the above post to reflect the correct price.

[mallenexpensify]

@StevenKKC , we're not having much luck, I'm going to leave this open for now, please continue to try to get your Upwork account verified.

[luacmartins]

still trying to figure out payment

[mallenexpensify]

Bumping to monthly. @luacmartins , @rushatgabhane , would either of you like to be unassigned?
The alternative would be to close, but I feel weird about closing without issuing payment, even if we're currently unable to

[luacmartins]

Still figuring out payment

[mallenexpensify]

Gonna close, I'll get emails if comments are left here and can reopen if/when needed