[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Workspaces - Name highlights on select member on invite page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to Settings > Workspaces >members
2. click on invite button
3. select any member

Expected Result:

name should be highlighted even if member is not selected

Actual Result:

name highlights on select member

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.At.1.20.24.Pm.mp4

Recording.1322.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692777018489079

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[b4s36t4]

I think this behaviour is intended, happening same on prod too.

[NikkiWines]

Behavior seems to be the same on staging and prod, just with a slightly different UI - not a blocker. Not even sure if this is really a bug. cc: @maddylewis to confirm

Screen.Recording.2023-08-24.at.15.02.34.mov

[aldo-expensify]

@NikkiWines I think this is referring to the email (login) not being bold anymore for elements that are unselected

[NikkiWines]

Oh hmm, yeah I definitely took "highlight" to mean that the whole row color was changed 🤔

@shawnborton can you confirm if the new UI styles are expected here?

[maddylewis]

OIC - the top line is no longer bolded. ok ya, let's see what Shawny says.

[aldo-expensify]

It is likely that this regression was caused by this big PR: #22622 which caused a few other regressions. It changed stuff in the workspace member page.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: refactor: SelectionList multiple selection #22622
• [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Looks like Rory's taken care of that already here
• [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - this PR didn't have clear QA steps and I don't think a supplementary discussion is warranted. Some steps were skipped and we saw regressions as a result. New steps don't need to be added.
• [@NikkiWines] Determine if we should create a regression test for this bug. N/A See above
• [@NikkiWines] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A see above.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[sakluger]

A single PR fixed four different GH issues, and @gadhiyamanan is already getting paid for reporting #25890 (which was fixed by the same PR). @maddylewis I don't think we need to pay multiple reporting bonuses when for the same root cause, I'll leave it up to you.

[gadhiyamanan]

@sakluger all the issues are different and have different root cause. It was handled in single pr because it was regression from selection list PR and author created one PR to handle all the issues and i think it's eligible for reporting bonus

[maddylewis]

thanks for clarifying @gadhiyamanan - i will process the reporting bonus to you for this particular issue.

[maddylewis]

offer sent

[gadhiyamanan]

@maddylewis offer accepted, thanks!

[maddylewis]

paid!